Skip to content

Commit 1ff8589

Browse files
committed
perform refactoring
1 parent 7cb2af1 commit 1ff8589

37 files changed

Lines changed: 24 additions & 590 deletions

File tree

logics/src/main/java/dev/stashy/extrasounds/logics/SoundManager.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package dev.stashy.extrasounds.logics;
22

3-
import com.google.common.collect.Sets;
43
import dev.stashy.extrasounds.logics.debug.DebugUtils;
54
import dev.stashy.extrasounds.logics.entry.SoundPackLoader;
65
import dev.stashy.extrasounds.logics.impl.VersionedHotbarSoundHandler;
@@ -27,6 +26,7 @@
2726
import org.apache.logging.log4j.LogManager;
2827
import org.apache.logging.log4j.Logger;
2928

29+
import java.util.HashSet;
3030
import java.util.Objects;
3131
import java.util.Set;
3232

@@ -48,7 +48,7 @@ public final class SoundManager {
4848

4949
public SoundManager() {
5050
this.hotbarSoundHandler = VersionedHotbarSoundHandler.newInstance();
51-
this.missingSoundId = Sets.newHashSet();
51+
this.missingSoundId = new HashSet<>();
5252
this.lastPlayed = 0;
5353
this.quickMovingItem = Items.AIR;
5454
}

logics/src/main/java/dev/stashy/extrasounds/logics/VersionedMain.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package dev.stashy.extrasounds.logics;
22

3-
import com.google.common.collect.Maps;
43
import dev.stashy.extrasounds.logics.impl.state.InventoryClickState;
54
import dev.stashy.extrasounds.logics.runtime.VersionedSoundEventWrapper;
65
import me.lonefelidae16.groominglib.Util;
@@ -14,6 +13,7 @@
1413
import net.minecraft.util.Identifier;
1514
import net.minecraft.util.collection.IndexedIterable;
1615

16+
import java.util.HashMap;
1717
import java.util.Map;
1818
import java.util.function.Predicate;
1919

@@ -33,7 +33,7 @@ public static VersionedMain newInstance() {
3333
* Predicate in this value will be passed an instance of an {@link InventoryClickState}.<br>
3434
* Item -&gt; Predicate&lt;InventoryClickStatus&gt;
3535
*/
36-
protected static final Map<Item, Predicate<InventoryClickState>> IGNORE_SOUND_PREDICATE_MAP = Util.make(Maps.newHashMap(), map -> {
36+
protected static final Map<Item, Predicate<InventoryClickState>> IGNORE_SOUND_PREDICATE_MAP = Util.make(new HashMap<>(), map -> {
3737
map.put(Items.BUNDLE, status -> {
3838
return status.isRMB && !(status.slot instanceof CreativeInventoryScreen.LockableSlot);
3939
});

logics/src/main/java/dev/stashy/extrasounds/logics/entry/SoundPackLoader.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package dev.stashy.extrasounds.logics.entry;
22

3-
import com.google.common.collect.Sets;
43
import com.google.gson.*;
54
import dev.stashy.extrasounds.logics.ExtraSounds;
65
import dev.stashy.extrasounds.logics.SoundManager;
@@ -153,7 +152,7 @@ public static void init() {
153152
*/
154153
private static void processSounds(Map<String, SoundGenerator> soundGenerator, Map<String, SoundEntry> resource) {
155154
final SoundEntry fallbackSoundEntry = Sounds.aliased(SoundManager.FALLBACK_SOUND_EVENT);
156-
final Set<String> inSoundsJsonIds = Sets.newHashSet();
155+
final Set<String> inSoundsJsonIds = new HashSet<>();
157156
final String fallbackSoundJson = GSON.toJson(fallbackSoundEntry);
158157
if (DebugUtils.SEARCH_UNDEF_SOUND) {
159158
try (InputStream stream = SoundPackLoader.class.getClassLoader().getResourceAsStream("assets/%s/%s".formatted(ExtraSounds.MODID, SOUNDS_JSON_ID.getPath()))) {

logics/src/main/java/dev/stashy/extrasounds/logics/impl/AbstractInteractionHandler.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import dev.stashy.extrasounds.logics.ExtraSounds;
44
import dev.stashy.extrasounds.logics.impl.state.ActionResultState;
5+
import dev.stashy.extrasounds.logics.mixin.access.FlowerPotBlockInvoker;
56
import dev.stashy.extrasounds.sounds.Sounds;
67
import net.minecraft.block.*;
78
import net.minecraft.block.entity.BlockEntity;
@@ -100,7 +101,7 @@ public final void onUse(ClientPlayerEntity player, BlockPos blockPos, ActionResu
100101
(this.block instanceof FlowerPotBlock potBlock) &&
101102
actionResult == ActionResultState.SUCCESS
102103
) {
103-
if (!potBlock.isEmpty()) {
104+
if (!((FlowerPotBlockInvoker) potBlock).invokeIsEmpty()) {
104105
// Take from pot
105106
ExtraSounds.MANAGER.blockInteract(potBlock.getContent().asItem(), blockPos);
106107
} else {
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
package dev.stashy.extrasounds.logics.mixin.access;
2+
3+
import net.minecraft.block.FlowerPotBlock;
4+
import org.spongepowered.asm.mixin.Mixin;
5+
import org.spongepowered.asm.mixin.gen.Invoker;
6+
7+
@Mixin(FlowerPotBlock.class)
8+
public interface FlowerPotBlockInvoker {
9+
@Invoker("isEmpty")
10+
boolean invokeIsEmpty();
11+
}

versioned/es1.20/src/main/java/dev/stashy/extrasounds/mc1_20/mixin/action/item/ClientPlayerEntityMixin.java renamed to logics/src/main/java/dev/stashy/extrasounds/logics/mixin/action/item/ClientPlayerEntityMixin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package dev.stashy.extrasounds.mc1_20.mixin.action.item;
1+
package dev.stashy.extrasounds.logics.mixin.action.item;
22

33
import com.mojang.authlib.GameProfile;
44
import dev.stashy.extrasounds.logics.ExtraSounds;
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
accessWidener v2 named
2-
accessible method net/minecraft/block/FlowerPotBlock isEmpty ()Z
32
accessible class net/minecraft/client/gui/screen/ingame/CreativeInventoryScreen$LockableSlot

logics/src/main/resources/extrasounds.logics.mixins.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@
44
"package": "dev.stashy.extrasounds.logics.mixin",
55
"compatibilityLevel": "JAVA_17",
66
"client": [
7+
"access.FlowerPotBlockInvoker",
8+
79
"action.entity.LivingEntityMixin",
10+
"action.item.ClientPlayerEntityMixin",
811
"hotbar.MinecraftClientMixin",
912
"inventory.ClientPlayerInteractionManagerMixin",
1013
"inventory.HandledScreenMixin",

versioned/es1.18.2/src/main/java/dev/stashy/extrasounds/mc1_18_2/mixin/action/item/ClientPlayerEntityMixin.java

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)