Chore: updates by php-cs-fixer and rector

Author: dgvirtual

src/Auth/Actions/EmailActivator.php

@@ -8,7 +8,6 @@
 use CodeIgniter\Exceptions\PageNotFoundException;
 use CodeIgniter\HTTP\IncomingRequest;
 use CodeIgniter\HTTP\RedirectResponse;
-use CodeIgniter\HTTP\Response;
 use CodeIgniter\I18n\Time;
 use CodeIgniter\Shield\Authentication\Actions\EmailActivator as ShieldEmailActivator;
 use CodeIgniter\Shield\Authentication\Authenticators\Session;

src/Core/Namespaces.php

@@ -52,7 +52,6 @@ public static function register(): void
         // Insert the namespaces into the psr4 array in the autoloader
         // to ensure that Bonfire's files get loader prior to vendor files
         $rp = new ReflectionProperty($autoloader, 'prefixes');
-        $rp->setAccessible(true);
 
         $prefixes = $rp->getValue($autoloader);
         $keys     = array_keys($prefixes);

src/Core/Traits/HasMeta.php

@@ -236,7 +236,7 @@ public function syncMeta(array $post): void
             }
 
             foreach (array_keys($fields) as $field) {
-                $field    = strtolower($field);
+                $field    = strtolower((string) $field);
                 $existing = array_key_exists($field, $this->meta);
                 // add to keep list
                 $legal[] = $field;

src/Menus/MenuItem.php

@@ -84,7 +84,7 @@ public function __construct(?array $data = null)
         }
 
         foreach ($data as $key => $value) {
-            $method = 'set' . ucfirst($key);
+            $method = 'set' . ucfirst((string) $key);
             if (method_exists($this, $method)) {
                 $this->{$method}($value);
             }

src/Tools/Libraries/Logs.php

@@ -118,7 +118,7 @@ public function countLogLevels($filePath): string
 
         // Count occurrences of each level
         foreach ($levels as $level) {
-            $counts[$level] = substr_count($fileContent, $level);
+            $counts[$level] = substr_count($fileContent, (string) $level);
         }
 
         // Remove entries with value 0

src/Widgets/Types/Charts/ChartDataset.php

@@ -48,7 +48,7 @@ public function __construct(?array $data = null)
         }
 
         foreach ($data as $key => $value) {
-            $method = 'set' . ucfirst($key);
+            $method = 'set' . ucfirst((string) $key);
             if (method_exists($this, $method)) {
                 $this->{$method}($value);
             }

src/Widgets/Types/Charts/ChartsItem.php

@@ -115,7 +115,7 @@ public function __construct(?array $data = null)
         }
 
         foreach ($data as $key => $value) {
-            $method = 'set' . ucfirst($key);
+            $method = 'set' . ucfirst((string) $key);
             if (method_exists($this, $method)) {
                 $this->{$method}($value);
             }

src/Widgets/Types/Stats/StatsItem.php

@@ -90,7 +90,7 @@ public function __construct(?array $data = null)
         }
 
         foreach ($data as $key => $value) {
-            $method = 'set' . ucfirst($key);
+            $method = 'set' . ucfirst((string) $key);
             if (method_exists($this, $method)) {
                 $this->{$method}($value);
             }

tests/CommonTest.php

@@ -18,17 +18,6 @@ public static function setUpBeforeClass(): void
         helper('setting');
     }
 
-    public static function provideAppDate(): iterable
-    {
-        return [
-            ['m/d/Y', 'g:i A', false, '01/15/2021'],
-            ['m/d/Y', 'g:i A', true, '01/15/2021 3:32 PM'],
-            ['m/d/Y', 'H:i', true, '01/15/2021 15:32'],
-            ['d/m/Y', 'g:i A', false, '15/01/2021'],
-            ['M j, Y', 'g:i A', false, 'Jan 15, 2021'],
-        ];
-    }
-
     #[DataProvider('provideAppDate')]
     public function testAppDate(string $format, string $timeFormat, bool $includeTime, string $expected)
     {
@@ -40,4 +29,15 @@ public function testAppDate(string $format, string $timeFormat, bool $includeTim
 
         $this->assertSame($expected, \app_date($time, $includeTime));
     }
+
+    public static function provideAppDate(): iterable
+    {
+        return [
+            ['m/d/Y', 'g:i A', false, '01/15/2021'],
+            ['m/d/Y', 'g:i A', true, '01/15/2021 3:32 PM'],
+            ['m/d/Y', 'H:i', true, '01/15/2021 15:32'],
+            ['d/m/Y', 'g:i A', false, '15/01/2021'],
+            ['M j, Y', 'g:i A', false, 'Jan 15, 2021'],
+        ];
+    }
 }