chrisbutler:node-sass breaks on Meteor 1.4

[persac]

Hi, thanks for the great work.

Unfortunately, the chrisbutler:node-sass package won’t add on Meteor 1.4. Now that Meteor natively supports NPM, would it be an option to switch to the NPM node-sass package for SCSS support?

If I knew where to start in making such a change, I would be happy to help. But I am not that guy.

Cheers,
Casper

[johanbrook]

Aight, on it. It probably needs to be recompiled for 1.4.x. ping @chrisbutler.

Now that Meteor natively supports NPM, would it be an option to switch to the NPM node-sass package for SCSS support?

I still wanna keep some backwards compatibility for pre-1.3 versions of Meteor :)

[marvin-bitterlich]

Seems like @chrisbutler is not active at the moment. Is there some way to use sass in emails without this package?

[steve-ross]

how about using regular node-sass via npm ?

[steve-ross]

I'll take a look, we need it in a project that we just brought up to 1.4

[steve-ross]

Opened a pr #72

[persac]

@johanbrook Any chance to take a look at #72 by @steve-ross? Cheers!

[johanbrook]

Hey, for sure. Sorry for the delay; been offline for a week with no internet access.

[steve-ross]

Let me know if there is any cleanup to do. Was a late night when I dug in.
😄
On Tue, Aug 16, 2016 at 8:20 AM Johan Brook notifications@github.com
wrote:

Hey, for sure. Sorry for the delay; been offline for a week with no
internet access.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#71 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASJh_qUZQCrLP2lcXD6F0e04DMBbs3Gks5qgarwgaJpZM4Jbvkd
.

Oak.Works

Steve Ross - CTO
O 268-0444

M 344-8113
[IM] steve@oak.works

[persac]

@johanbrook, sorry to bother you again, is there anything I can do to make #72 happen? Email styling has become a real pain since SASS support is broken. Thanks in advance!

[johanbrook]

@persac Thanks for the ping. On this now. Ping @steve-ross, commented on the PR.

[sotarules]

+1 on this. I see that lookback emails has explicit test for the presence of chrisbutler:node-sass. I tried to install native node-sass NPM assigning global variable sass = Npm.require("node-sass") but this didn't work due to that explict test (and possibly other issues yet to be found).

[steve-ross]

Sorry been slammed at the office this week. I'll check out the comment and
update the PR
On Fri, Aug 26, 2016 at 3:54 PM David Lynch notifications@github.com
wrote:

+1 on this. I see that lookback emails has explicit test for the presence
of chrisbutler:node-sass. I tried to install native node-sass NPM
assigning global variable sass = Npm.require("node-sass") but this didn't
work due to that explict test (and possibly other issues yet to be found).

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#71 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASJh3UYWa-6cb_8xWy_ttIUmFqBr0i1ks5qj0RmgaJpZM4Jbvkd
.

Oak.Works

Steve Ross - CTO
O 268-0444

M 344-8113
[IM] steve@oak.works

[johanbrook]

+1 on this. I see that lookback emails has explicit test for the presence of chrisbutler:node-sass. I tried to install native node-sass NPM assigning global variable sass = Npm.require("node-sass") but this didn't work due to that explict test (and possibly other issues yet to be found).

I totally see how you mean, but I think we should avoid to shove Sass into people's builds if they don't need it, hence the weak dependency on chrisbutler:node-sass.

• One option is to fork and maintain a Meteor package of node-sass from npm.

• Another is to at runtime check of node-sass inclusion via npm:

  try {
    sass = require('node-sass');
  } catch (ex) {}