Skip to content

Commit 05b4e30

Browse files
authored
feat: implement row limit update (#124)
* feat: implement row limit update Added row limit update example. This required updating the extension SDK packages.
1 parent e3d7e94 commit 05b4e30

File tree

20 files changed

+1040
-191
lines changed

20 files changed

+1040
-191
lines changed

package-lock.json

+959-105
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

react/javascript/demo-core-sdk/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/components-providers": "1.5.34",
2626
"@looker/design-tokens": "3.1.1",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/demo-embeds/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/demo-extension-sdk/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/demo-external-api/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/file-download/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/file-upload/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
"@looker/design-tokens": "3.1.1",
2727
"@looker/i18n": "1.0.0",
2828
"@looker/embed-sdk": "^1.8.5",
29-
"@looker/extension-sdk": "23.20.0",
30-
"@looker/extension-sdk-react": "23.20.0",
29+
"@looker/extension-sdk": "23.20.1",
30+
"@looker/extension-sdk-react": "23.20.1",
3131
"@looker/icons": "1.5.21",
32-
"@looker/sdk": "23.20.0",
32+
"@looker/sdk": "23.20.1",
3333
"@looker/sdk-rtl": "21.6.1",
3434
"@styled-icons/material": "^10.28.0",
3535
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/helloworld-js/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/map-iframe/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/tile-sdk/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/javascript/tile-sdk/src/components/Inspector/components/EventTester/EventTester.js

+29-34
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ export const EventTester = () => {
6060
visualizationData,
6161
visualizationSDK,
6262
} = useContext(ExtensionContext40)
63-
const [runDashboard, setRunDashboard] = useState(false)
63+
const [run, setRun] = useState(false)
6464
const openDrillMenuButtonRef = useRef()
6565
const toggleCrossFilterButtonRef = useRef()
6666

@@ -130,23 +130,10 @@ export const EventTester = () => {
130130
return event
131131
}, [])
132132

133-
const triggerClick = useCallback((event) => {
134-
// Taken from custom visualizations 2
135-
const defaultColors = {
136-
red: '#F36254',
137-
green: '#4FBC89',
138-
yellow: '#FCF758',
139-
white: '#FFFFFF',
133+
const updateRowLimitClick = useCallback((event) => {
134+
if (visualizationSDK) {
135+
visualizationSDK.updateRowLimit(50)
140136
}
141-
tileSDK.trigger(
142-
'updateConfig',
143-
[
144-
{ lowColor: defaultColors.red },
145-
{ midColor: defaultColors.white },
146-
{ highColor: defaultColors.green },
147-
],
148-
event
149-
)
150137
}, [])
151138

152139
const toggleCrossFilterClick = useCallback(
@@ -197,17 +184,21 @@ export const EventTester = () => {
197184

198185
const updateFiltersClick = useCallback(() => {
199186
const updatedFilter = {}
200-
Object.entries(dashboardFilters || {}).forEach(([key, value]) => {
201-
updatedFilter[key] = value
202-
if (key === 'State') {
203-
updatedFilter[key] =
204-
value === 'California' ? 'Washington' : 'California'
205-
} else if (typeof value === 'string') {
206-
updatedFilter[key] = value.split('').reverse().join('')
207-
}
208-
})
209-
tileSDK.updateFilters(updatedFilter, runDashboard)
210-
}, [dashboardFilters, runDashboard])
187+
if (Object.entries(dashboardFilters || {}).length === 0) {
188+
updatedFilter.State = 'Washington'
189+
} else {
190+
Object.entries(dashboardFilters || {}).forEach(([key, value]) => {
191+
updatedFilter[key] = value
192+
if (key === 'State') {
193+
updatedFilter[key] =
194+
value === 'California' ? 'Washington' : 'California'
195+
} else if (typeof value === 'string') {
196+
updatedFilter[key] = value.split('').reverse().join('')
197+
}
198+
})
199+
}
200+
tileSDK.updateFilters(updatedFilter, run)
201+
}, [dashboardFilters, run])
211202

212203
const openScheduleDialogClick = useCallback(() => {
213204
tileSDK.openScheduleDialog()
@@ -249,11 +240,11 @@ export const EventTester = () => {
249240
Test stop dashboard
250241
</ButtonOutline>
251242
<ButtonOutline
252-
onClick={triggerClick}
243+
onClick={updateRowLimitClick}
253244
width="100%"
254245
disabled={!visualizationData}
255246
>
256-
Test trigger
247+
Update row limit
257248
</ButtonOutline>
258249
<ButtonOutline
259250
onClick={openDrillMenuClick}
@@ -279,9 +270,9 @@ export const EventTester = () => {
279270
Test update filters
280271
</ButtonOutline>
281272
<FieldToggleSwitch
282-
label="Run dashboard"
283-
onChange={(event) => setRunDashboard(event.target.checked)}
284-
on={runDashboard}
273+
label="Run"
274+
onChange={(event) => setRun(event.target.checked)}
275+
on={run}
285276
></FieldToggleSwitch>
286277
<ButtonOutline
287278
onClick={openScheduleDialogClick}
@@ -290,7 +281,11 @@ export const EventTester = () => {
290281
>
291282
Test open schedule dialog
292283
</ButtonOutline>
293-
<ButtonOutline onClick={updateTileClick} width="100%">
284+
<ButtonOutline
285+
onClick={updateTileClick}
286+
width="100%"
287+
disabled={isExploring}
288+
>
294289
Update title title
295290
</ButtonOutline>
296291
</Grid>

react/javascript/tile-visualization/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"@looker/design-tokens": "3.1.1",
2626
"@looker/i18n": "1.0.0",
2727
"@looker/embed-sdk": "^1.8.5",
28-
"@looker/extension-sdk": "23.20.0",
29-
"@looker/extension-sdk-react": "23.20.0",
28+
"@looker/extension-sdk": "23.20.1",
29+
"@looker/extension-sdk-react": "23.20.1",
3030
"@looker/icons": "1.5.21",
31-
"@looker/sdk": "23.20.0",
31+
"@looker/sdk": "23.20.1",
3232
"@looker/sdk-rtl": "21.6.1",
3333
"@styled-icons/material": "^10.28.0",
3434
"@styled-icons/material-outlined": "^10.34.0",

react/typescript/access-key-demo/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@
2727
"@looker/design-tokens": "3.1.1",
2828
"@looker/i18n": "1.0.0",
2929
"@looker/embed-sdk": "^1.8.5",
30-
"@looker/extension-sdk": "23.20.0",
31-
"@looker/extension-sdk-react": "23.20.0",
30+
"@looker/extension-sdk": "23.20.1",
31+
"@looker/extension-sdk-react": "23.20.1",
3232
"@looker/icons": "1.5.21",
33-
"@looker/sdk": "23.20.0",
33+
"@looker/sdk": "23.20.1",
3434
"@looker/sdk-rtl": "21.6.1",
3535
"@styled-icons/material": "^10.28.0",
3636
"@styled-icons/material-outlined": "^10.34.0",

react/typescript/helloworld-ts/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
"@looker/design-tokens": "3.1.1",
2727
"@looker/embed-sdk": "^1.8.5",
2828
"@looker/i18n": "1.0.0",
29-
"@looker/extension-sdk": "23.20.0",
30-
"@looker/extension-sdk-react": "23.20.0",
29+
"@looker/extension-sdk": "23.20.1",
30+
"@looker/extension-sdk-react": "23.20.1",
3131
"@looker/icons": "1.5.21",
32-
"@looker/sdk": "23.20.0",
32+
"@looker/sdk": "23.20.1",
3333
"@looker/sdk-rtl": "21.6.1",
3434
"@styled-icons/material": "^10.28.0",
3535
"@styled-icons/material-outlined": "^10.34.0",

react/typescript/kitchensink/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
"@looker/design-tokens": "3.1.1",
2727
"@looker/i18n": "1.0.0",
2828
"@looker/embed-sdk": "^1.8.5",
29-
"@looker/extension-sdk": "23.20.0",
30-
"@looker/extension-sdk-react": "23.20.0",
29+
"@looker/extension-sdk": "23.20.1",
30+
"@looker/extension-sdk-react": "23.20.1",
3131
"@looker/icons": "1.5.21",
32-
"@looker/sdk": "23.20.0",
32+
"@looker/sdk": "23.20.1",
3333
"@looker/sdk-rtl": "21.6.1",
3434
"@styled-icons/material": "^10.28.0",
3535
"@styled-icons/material-outlined": "^10.34.0",

react/typescript/looks-query-redux/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
"@looker/design-tokens": "3.1.1",
2727
"@looker/i18n": "1.0.0",
2828
"@looker/embed-sdk": "^1.8.5",
29-
"@looker/extension-sdk": "23.20.0",
30-
"@looker/extension-sdk-react": "23.20.0",
29+
"@looker/extension-sdk": "23.20.1",
30+
"@looker/extension-sdk-react": "23.20.1",
3131
"@looker/icons": "1.5.21",
32-
"@looker/sdk": "23.20.0",
32+
"@looker/sdk": "23.20.1",
3333
"@looker/sdk-rtl": "21.6.1",
3434
"@styled-icons/material": "^10.28.0",
3535
"@styled-icons/material-outlined": "^10.34.0",

react/typescript/looks-query/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,10 @@
2626
"@looker/design-tokens": "3.1.1",
2727
"@looker/i18n": "1.0.0",
2828
"@looker/embed-sdk": "^1.8.5",
29-
"@looker/extension-sdk": "23.20.0",
30-
"@looker/extension-sdk-react": "23.20.0",
29+
"@looker/extension-sdk": "23.20.1",
30+
"@looker/extension-sdk-react": "23.20.1",
3131
"@looker/icons": "1.5.21",
32-
"@looker/sdk": "23.20.0",
32+
"@looker/sdk": "23.20.1",
3333
"@looker/sdk-rtl": "21.6.1",
3434
"@styled-icons/material": "^10.28.0",
3535
"@styled-icons/material-outlined": "^10.34.0",

scripts/update_packages.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ const packages = {
3131
'@looker/i18n': '1.0.0',
3232
'@looker/design-tokens': '3.1.1',
3333
'@looker/embed-sdk': '^1.8.5',
34-
'@looker/extension-sdk': '23.20.0',
35-
'@looker/extension-sdk-react': '23.20.0',
34+
'@looker/extension-sdk': '23.20.1',
35+
'@looker/extension-sdk-react': '23.20.1',
3636
'@looker/icons': '1.5.21',
37-
'@looker/sdk': '23.20.0',
37+
'@looker/sdk': '23.20.1',
3838
'@looker/sdk-rtl': '21.6.1',
3939
react: '^16.14.0',
4040
'react-content-loader': '^4.0.1',

vanilla/counter-ts/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
"node": ">=14"
1717
},
1818
"dependencies": {
19-
"@looker/extension-sdk": "23.20.0",
20-
"@looker/sdk": "23.20.0",
19+
"@looker/extension-sdk": "23.20.1",
20+
"@looker/sdk": "23.20.1",
2121
"@looker/sdk-rtl": "21.6.1"
2222
},
2323
"devDependencies": {

vanilla/counter/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
"node": ">=14"
1717
},
1818
"dependencies": {
19-
"@looker/extension-sdk": "23.20.0",
20-
"@looker/sdk": "23.20.0",
19+
"@looker/extension-sdk": "23.20.1",
20+
"@looker/sdk": "23.20.1",
2121
"@looker/sdk-rtl": "21.6.1"
2222
},
2323
"devDependencies": {

0 commit comments

Comments
 (0)