always use eth_personal_sign

[lukezhangstudio]

Because of the way Ethers.js implements a workaround for metamask, we have been effectively using personal.sign. Let's just switch to using personal_sign explicitly in case someone imports addressmapper without using dposuser.

Our own workaround:

loom-js/src/solidity-helpers.ts

Line 24 in a128250

return new ethers.providers.Web3Provider(provider).getSigner()

[lukezhangstudio]

Example of where we use .sign instead of personal.sign

loom-js/src/contracts/address-mapper.ts

Line 49 in 02ef5d5

const sign = await ethersSigner.signAsync(hash)

[eduardonunesp]

@lukezhangstudio that function is passing an interface for IEthereumSigner, so in order to use the personal.sign the user should pass the EthersSigner to that function

async addIdentityMappingAsync(
  from: Address,
  to: Address,
  ethersSigner: IEthereumSigner
): Promise<Uint8Array | void> {
  const mappingIdentityRequest = new AddressMapperAddIdentityMappingRequest()
  mappingIdentityRequest.setFrom(from.MarshalPB())
  mappingIdentityRequest.setTo(to.MarshalPB())

  const hash = soliditySha3(
    {
      type: 'address',
      value: from.local.toString().slice(2)
    },
    {
      type: 'address',
      value: to.local.toString().slice(2)
    }
  )

  const sign = await ethersSigner.signAsync(hash)
  mappingIdentityRequest.setSignature(sign)

  return this.callAsync<void>('AddIdentityMapping', mappingIdentityRequest)
}

loom-js/src/solidity-helpers.ts

Line 47 in 877edfc

export class EthersSigner implements IEthereumSigner {

Instead of Web3Signer which not implements personal_sign

loom-js/src/solidity-helpers.ts

Line 79 in 877edfc

export class Web3Signer implements IEthereumSigner {

[eduardonunesp]

@lukezhangstudio could you please confirm if my comment above makes sense?

loom-js/src/tests/e2e/address-mapper-tests.ts

Line 47 in 877edfc

await addressMapper.addIdentityMappingAsync(from, to, ethersSigner)