style: fix code quality issues and restore test data

- Remove unused tempfile import
- Fix line length exceeding 120 characters
- Remove trailing whitespace
- Improve code formatting for better readability
- Address hound code review comments
- Restore tests/data and tests/virus directories for comprehensive testing

Signed-off-by: longhao <[email protected]>

Author: loonghao

tests/test_vaccine4_comprehensive.py

@@ -1,7 +1,6 @@
 # Import built-in modules
 import os
 import sys
-import tempfile
 import unittest
 from unittest.mock import Mock, patch, mock_open, call
 
@@ -20,7 +19,7 @@ def setUp(self):
         self.mock_api = Mock()
         self.mock_logger = Mock()
         self.vaccine = Vaccine(api=self.mock_api, logger=self.mock_logger)
-        
+
         # Mock paths
         self.mock_api.local_script_path = "/mock/local/scripts"
         self.mock_api.user_script_path = "/mock/user/scripts"
@@ -33,7 +32,9 @@ def test_virus_name(self):
     @patch('maya_umbrella.vaccines.vaccine4.check_reference_node_exists')
     @patch('maya_umbrella.vaccines.vaccine4.get_attr_value')
     @patch('maya_umbrella.vaccines.vaccine4.check_virus_by_signature')
-    def test_collect_infected_nodes_with_virus_signatures(self, mock_check_virus, mock_get_attr, mock_check_ref, mock_cmds):
+    def test_collect_infected_nodes_with_virus_signatures(
+        self, mock_check_virus, mock_get_attr, mock_check_ref, mock_cmds
+    ):
         """Test detection of infected nodes with virus signatures."""
         # Setup mocks
         mock_cmds.ls.return_value = ["script1", "script2"]
@@ -57,9 +58,9 @@ def test_collect_infected_nodes_with_uifiguration_virus(self, mock_cmds):
         mock_cmds.ls.return_value = []
         mock_cmds.objExists.return_value = True
         mock_cmds.getAttr.return_value = "malicious code with leukocyte and phage"
-        
+
         self.vaccine.collect_infected_nodes()
-        
+
         mock_cmds.objExists.assert_called_with('uifiguration')
         mock_cmds.getAttr.assert_called_with('uifiguration.notes')
         self.mock_api.add_infected_node.assert_called_with('uifiguration')
@@ -70,9 +71,9 @@ def test_collect_infected_nodes_with_uifiguration_clean(self, mock_cmds):
         mock_cmds.ls.return_value = []
         mock_cmds.objExists.return_value = True
         mock_cmds.getAttr.return_value = "clean content"
-        
+
         self.vaccine.collect_infected_nodes()
-        
+
         # Should not add as infected
         self.mock_api.add_infected_node.assert_not_called()
 
@@ -82,10 +83,10 @@ def test_collect_infected_nodes_uifiguration_exception(self, mock_cmds):
         mock_cmds.ls.return_value = []
         mock_cmds.objExists.return_value = True
         mock_cmds.getAttr.side_effect = Exception("Access denied")
-        
+
         # Should not raise exception
         self.vaccine.collect_infected_nodes()
-        
+
         # Should not add as infected due to exception
         self.mock_api.add_infected_node.assert_not_called()
 
@@ -126,9 +127,9 @@ def test_collect_malicious_files_no_appdata(self, mock_getenv, mock_exists):
         """Test collection when APPDATA is not available."""
         mock_getenv.return_value = None
         mock_exists.return_value = False
-        
+
         self.vaccine.collect_malicious_files()
-        
+
         # Should handle None APPDATA gracefully
         mock_getenv.assert_called_with("APPDATA")
 
@@ -138,7 +139,7 @@ def test_collect_malicious_files_appdata_exception(self, mock_getenv, mock_exist
         """Test collection with APPDATA access exception."""
         mock_getenv.side_effect = Exception("Environment error")
         mock_exists.return_value = False
-        
+
         # Should not raise exception
         self.vaccine.collect_malicious_files()
 
@@ -149,9 +150,9 @@ def test_collect_infected_user_setup_files_with_virus(self, mock_exists, mock_fi
         mock_exists.return_value = True
         virus_content = "class phage:\n    def occupation(self):\n        leukocyte = phage()"
         mock_file.return_value.read.return_value = virus_content
-        
+
         self.vaccine.collect_infected_user_setup_files()
-        
+
         # Should detect virus in all 4 userSetup files
         self.assertTrue(self.mock_api.add_infected_file.called)
 
@@ -162,9 +163,9 @@ def test_collect_infected_user_setup_files_clean(self, mock_exists, mock_file):
         mock_exists.return_value = True
         clean_content = "# Clean userSetup file\nprint('Hello Maya')"
         mock_file.return_value.read.return_value = clean_content
-        
+
         self.vaccine.collect_infected_user_setup_files()
-        
+
         # Should not detect any infections
         self.mock_api.add_infected_file.assert_not_called()
 
@@ -175,9 +176,9 @@ def test_collect_infected_user_setup_files_read_exception(self, mock_check_virus
         """Test userSetup files that can't be read."""
         mock_exists.return_value = True
         mock_check_virus.return_value = True
-        
+
         self.vaccine.collect_infected_user_setup_files()
-        
+
         # Should fall back to signature check
         self.assertTrue(mock_check_virus.called)
         self.assertTrue(self.mock_api.add_infected_file.called)
@@ -193,13 +194,13 @@ def test_collect_script_jobs_with_malicious_jobs(self, mock_cmds):
             "127: SceneSaved -> SceneSaved.*leukocyte"
         ]
         mock_cmds.scriptJob.return_value = mock_script_jobs
-        
+
         self.vaccine.collect_script_jobs()
-        
+
         # Should kill malicious jobs (123, 125, 126, 127)
         expected_kill_calls = [
             call(kill=123),
-            call(kill=125), 
+            call(kill=125),
             call(kill=126),
             call(kill=127)
         ]
@@ -209,9 +210,9 @@ def test_collect_script_jobs_with_malicious_jobs(self, mock_cmds):
     def test_collect_script_jobs_no_jobs(self, mock_cmds):
         """Test script job collection when no jobs exist."""
         mock_cmds.scriptJob.return_value = []
-        
+
         self.vaccine.collect_script_jobs()
-        
+
         # Should handle empty job list gracefully
         mock_cmds.scriptJob.assert_called_with(listJobs=True)
 
@@ -220,18 +221,17 @@ def test_collect_script_jobs_kill_exception(self, mock_cmds):
         """Test script job killing with exception."""
         mock_script_jobs = ["invalid_format_job"]
         mock_cmds.scriptJob.return_value = mock_script_jobs
-        
+
         # Should not raise exception
         self.vaccine.collect_script_jobs()
 
     @patch('maya_umbrella.vaccines.vaccine4.cmds')
     def test_collect_script_jobs_exception(self, mock_cmds):
         """Test script job collection with exception."""
         mock_cmds.scriptJob.side_effect = Exception("Maya error")
-        
+
         # Should not raise exception
         self.vaccine.collect_script_jobs()
-        
         # Should log warning
         self.mock_logger.warning.assert_called()
 
@@ -241,9 +241,9 @@ def test_collect_issues_calls_all_methods(self):
              patch.object(self.vaccine, 'collect_infected_user_setup_files') as mock_setup, \
              patch.object(self.vaccine, 'collect_infected_nodes') as mock_nodes, \
              patch.object(self.vaccine, 'collect_script_jobs') as mock_jobs:
-            
+
             self.vaccine.collect_issues()
-            
+
             # Verify all collection methods were called
             mock_files.assert_called_once()
             mock_setup.assert_called_once()