fix(quoteforge[typecheck]): split tsconfig for src/studio and fix remaining type errors

Author: lordvins226

package.json

@@ -8,7 +8,7 @@
     "qf": "./src/cli/index.ts"
   },
   "scripts": {
-    "typecheck": "tsc --noEmit",
+    "typecheck": "tsc --noEmit && tsc --noEmit -p studio",
     "quoteforge": "bun run src/cli/index.ts",
     "qf": "bun run src/cli/index.ts",
     "build:binary": "bun run scripts/build-binaries.ts",

src/__tests__/image-resolver.test.ts

@@ -71,8 +71,9 @@ describe("resolveImageBlocks", () => {
       ],
     };
     const out = resolveImageBlocks(deck, dir);
-    expect(out.slides[0].blocks[0]).toEqual({ type: "text", content: "unchanged" });
-    expect((out.slides[0].blocks[1] as { src: string }).src.startsWith("data:image/png;base64,")).toBe(true);
+    const slide = out.slides[0]!;
+    expect(slide.blocks[0]).toEqual({ type: "text", content: "unchanged" });
+    expect((slide.blocks[1] as { src: string }).src.startsWith("data:image/png;base64,")).toBe(true);
   });
 });
 

src/__tests__/slide-renderer.test.ts

@@ -3,6 +3,8 @@ import { buildSlideCardContent } from "../renderer/slide-renderer.js";
 import { resolveDimensions } from "../renderer/dimensions.js";
 import type { DeckContent } from "../cli/utils/validator.js";
 
+type DeckSlide = DeckContent["slides"][number];
+
 function makeDeck(overrides: Partial<DeckContent["defaults"]>): DeckContent {
   return {
     type: "deck",
@@ -36,9 +38,9 @@ describe("buildSlideCardContent", () => {
 
   test("uses per-slide custom width/height when defaults are a preset", () => {
     const deck = makeDeck({ size: "instagram-sq" });
-    const slide = {
+    const slide: DeckSlide = {
       id: "slide-1",
-      size: "custom" as const,
+      size: "custom",
       width: 500,
       height: 700,
       blocks: [{ type: "text", content: "hello" }],
@@ -54,9 +56,9 @@ describe("buildSlideCardContent", () => {
 
   test("slide preset override with custom defaults uses preset dimensions", () => {
     const deck = makeDeck({ size: "custom", width: 1200, height: 900 });
-    const slide = {
+    const slide: DeckSlide = {
       id: "slide-1",
-      size: "instagram-sq" as const,
+      size: "instagram-sq",
       blocks: [{ type: "text", content: "hello" }],
     };
 

src/cli/commands/new.ts

@@ -85,7 +85,7 @@ export const newCommand = new Command("new")
       message: "Filename (without .json):",
       placeholder: type === "deck" ? "my-deck" : "my-card",
       validate: (val) => {
-        if (!val.trim()) return "Name is required";
+        if (!val || !val.trim()) return "Name is required";
         if (!/^[a-z0-9-]+$/.test(val)) return "Use kebab-case (lowercase, hyphens only)";
         return undefined;
       },

src/cli/utils/validator.ts

@@ -25,7 +25,7 @@ export const SIZES = {
   "custom":                { w: 0,    h: 0,    ratio: "free",   label: "Custom dimensions" },
 } as const;
 
-const sizeNames = Object.keys(SIZES) as [string, ...string[]];
+const sizeNames = Object.keys(SIZES) as [keyof typeof SIZES, ...(keyof typeof SIZES)[]];
 export const SizeNameSchema = z.enum(sizeNames);
 export type SizeName = z.infer<typeof SizeNameSchema>;
 

src/renderer/template-engine.ts

@@ -112,7 +112,7 @@ export function initials(name: string): string {
   const parts = name.trim().split(/\s+/).filter(Boolean);
   if (parts.length === 0) return "";
   if (parts.length === 1) return parts[0]!.slice(0, 2).toUpperCase();
-  return (parts[0]![0] + parts[parts.length - 1]![0]).toUpperCase();
+  return (parts[0]![0]! + parts[parts.length - 1]![0]!).toUpperCase();
 }
 
 env.addGlobal("initials", initials);

src/server/routes/export.ts

@@ -31,7 +31,7 @@ export async function exportRoute(req: Request): Promise<Response> {
 
   const buf = await renderCard(body.card, theme, body.size, body.scale ?? 2, undefined, undefined, body.fitContent ?? false);
 
-  return new Response(buf, {
+  return new Response(new Uint8Array(buf), {
     headers: {
       "Content-Type": "image/png",
       "Content-Disposition": "attachment; filename=quoteforge-export.png",

src/server/routes/exportDeck.ts

@@ -20,7 +20,7 @@ export async function exportDeckRoute(req: Request): Promise<Response> {
 
   const zipBuf = await buildZip(buffers, names);
 
-  return new Response(zipBuf, {
+  return new Response(new Uint8Array(zipBuf), {
     headers: {
       "Content-Type": "application/zip",
       "Content-Disposition": "attachment; filename=quoteforge-deck.zip",

src/server/routes/themes.ts

@@ -22,6 +22,9 @@ export async function themesRoute(req: Request, url: URL): Promise<Response> {
   const nameMatch = url.pathname.match(/^\/api\/themes\/([^/]+)$/);
   if (req.method === "PUT" && nameMatch) {
     const name = nameMatch[1];
+    if (!name) {
+      return new Response("Not found", { status: 404 });
+    }
     const body = await req.json();
     const theme = ThemeSchema.parse(body);
     const filePath = resolveThemeWrite(name);

studio/src/components/ui/ErrorBoundary.tsx

@@ -12,19 +12,19 @@ interface State {
 }
 
 export class ErrorBoundary extends Component<Props, State> {
-  state: State = { hasError: false, error: null };
+  override state: State = { hasError: false, error: null };
 
   static getDerivedStateFromError(error: Error): State {
     return { hasError: true, error: error.message };
   }
 
-  componentDidCatch(error: Error, info: ErrorInfo) {
+  override componentDidCatch(error: Error, info: ErrorInfo) {
     if (import.meta.env.DEV) {
       console.error(`[ErrorBoundary] ${this.props.fallback}:`, error, info);
     }
   }
 
-  render() {
+  override render() {
     if (this.state.hasError) {
       return (
         <div className="flex items-center justify-center h-full p-6">