Skip to content

Commit a1ac012

Browse files
committed
refactor(quoteforge[renderer]): use shared SafeInset type instead of inline redeclarations
1 parent 9038df8 commit a1ac012

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/renderer/renderer.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import type { CardContent, Theme, SizeName } from "../cli/utils/validator.js";
66
import { resolveChrome } from "./browser-resolver.js";
77
import { resolveDimensions } from "./dimensions.js";
88
import { computeContentClip } from "./fit-content.js";
9+
import type { SafeInset } from "./safe-aspect.js";
910

1011
async function launch(): Promise<Browser> {
1112
const { executablePath } = await resolveChrome();
@@ -20,7 +21,7 @@ export async function renderCardOnPage(
2021
scale = 2,
2122
meta?: Partial<RenderMeta>,
2223
fitContent = false,
23-
safeInset?: { top: number; right: number; bottom: number; left: number },
24+
safeInset?: SafeInset,
2425
): Promise<Buffer> {
2526
const dimensions = resolveDimensions({
2627
size,
@@ -73,7 +74,7 @@ export async function renderCard(
7374
meta?: Partial<RenderMeta>,
7475
browser?: Browser,
7576
fitContent = false,
76-
safeInset?: { top: number; right: number; bottom: number; left: number },
77+
safeInset?: SafeInset,
7778
): Promise<Buffer> {
7879
const ownBrowser = !browser;
7980
const b = browser ?? await launch();

src/renderer/template-engine.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { join } from "node:path";
44
import { buildFontImports } from "./font-loader.js";
55
import { templatesDir } from "../assetBundle.js";
66
import type { CardContent, Theme, Part, PartStyle } from "../cli/utils/validator.js";
7+
import type { SafeInset } from "./safe-aspect.js";
78

89
const TEMPLATES_DIR = templatesDir();
910
const IS_DEV = process.env.NODE_ENV === "development";
@@ -48,7 +49,7 @@ const DEFAULT_META: RenderMeta = {
4849
function buildCssVars(
4950
theme: Theme,
5051
dimensions: { w: number; h: number },
51-
safeInset: { top: number; right: number; bottom: number; left: number } = { top: 0, right: 0, bottom: 0, left: 0 },
52+
safeInset: SafeInset = { top: 0, right: 0, bottom: 0, left: 0 },
5253
): string {
5354
const shortSide = Math.min(dimensions.w, dimensions.h);
5455
const longSide = Math.max(dimensions.w, dimensions.h);
@@ -111,7 +112,7 @@ export function renderTemplate(
111112
theme: Theme,
112113
dimensions: { w: number; h: number } = { w: 1200, h: 675 },
113114
meta?: Partial<RenderMeta>,
114-
safeInset?: { top: number; right: number; bottom: number; left: number },
115+
safeInset?: SafeInset,
115116
): string {
116117
const resolvedMeta = { ...DEFAULT_META, ...meta };
117118
const fontImports = buildFontImports(theme);

0 commit comments

Comments
 (0)