tmp

Author: loserwang1024

fluss-client/src/main/java/org/apache/fluss/client/FlussConnection.java

@@ -152,7 +152,7 @@ public RemoteFileDownloader getOrCreateRemoteFileDownloader() {
                 if (securityTokenManager == null) {
                     // prepare security token manager
                     // create the admin read only gateway
-                    // todo: may addColumn retry logic when no any available tablet server?
+                    // todo: may add retry logic when no any available tablet server?
                     AdminReadOnlyGateway gateway =
                             GatewayClientProxy.createGatewayProxy(
                                     () ->

fluss-client/src/main/java/org/apache/fluss/client/admin/Admin.java

@@ -310,7 +310,7 @@ CompletableFuture<List<PartitionInfo>> listPartitionInfos(
      * </ul>
      *
      * @param tablePath The table path of the table.
-     * @param partitionSpec The partition spec to addColumn.
+     * @param partitionSpec The partition spec to add.
      * @param ignoreIfExists Flag to specify behavior when a partition with the given name already
      *     exists: if set to false, throw a PartitionAlreadyExistsException, if set to true, do
      *     nothing.

fluss-client/src/main/java/org/apache/fluss/client/lookup/LookupSender.java

@@ -107,7 +107,7 @@ public void run() {
             }
         }
 
-        // TODO if force close failed, addColumn logic to abort incomplete lookup requests.
+        // TODO if force close failed, add logic to abort incomplete lookup requests.
         LOG.debug("Shutdown of Fluss lookup sender I/O thread has completed.");
     }
 

fluss-client/src/main/java/org/apache/fluss/client/table/scanner/batch/BatchScanUtils.java

@@ -68,10 +68,10 @@ public static List<InternalRow> collectLimitedRows(List<BatchScanner> scanners,
                 CloseableIterator<InternalRow> iterator = scanner.pollBatch(DEFAULT_POLL_TIMEOUT);
                 if (iterator != null) {
                     rows.addAll(toList(iterator));
-                    // If the scanner has more data, addColumn it back to the queue
+                    // If the scanner has more data, add it back to the queue
                     scannerQueue.add(scanner);
                 } else {
-                    // Close the scanner if it has no more data, and not addColumn it back to the
+                    // Close the scanner if it has no more data, and not add it back to the
                     // queue
                     scanner.close();
                 }

fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/BucketScanStatus.java

@@ -24,7 +24,8 @@
 class BucketScanStatus {
     private long offset; // last consumed position
     private long highWatermark; // the high watermark from last fetch
-    // TODO addColumn resetStrategy and nextAllowedRetryTimeMs.
+    // TODO add
+    //  resetStrategy and nextAllowedRetryTimeMs.
 
     public BucketScanStatus() {
         this.offset = 0L;

fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/CompletedFetch.java

@@ -97,6 +97,7 @@ public CompletedFetch(
     //  from underlying record stream and arrow buffer.
     ScanRecord toScanRecord(LogRecord record) {
         GenericRow newRow = new GenericRow(selectedFieldGetters.length);
+        // todo: replace here or outside of this method.
         InternalRow internalRow = record.getRow();
         for (int i = 0; i < selectedFieldGetters.length; i++) {
             newRow.setField(i, selectedFieldGetters[i].getFieldOrNull(internalRow));

fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/LogFetcher.java

@@ -360,7 +360,7 @@ private synchronized void handleFetchLogResponse(
                             LogRecords logRecords = fetchResultForBucket.recordsOrEmpty();
                             if (!MemoryLogRecords.EMPTY.equals(logRecords)
                                     || fetchResultForBucket.getErrorCode() != Errors.NONE.code()) {
-                                // In oder to not signal notEmptyCondition, addColumn completed
+                                // In oder to not signal notEmptyCondition, add completed
                                 // fetch to
                                 // buffer until log records is not empty.
                                 DefaultCompletedFetch completedFetch =
@@ -432,7 +432,7 @@ private Map<Integer, FetchLogRequest> prepareFetchLogRequests() {
                 continue;
             }
 
-            // TODO addColumn select preferred read replica, currently we can only read from leader.
+            // TODO add select preferred read replica, currently we can only read from leader.
 
             Integer leader = getTableBucketLeader(tb);
             if (leader == null) {

fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/LogScannerImpl.java

@@ -86,7 +86,7 @@ public LogScannerImpl(
         this.tablePath = tableInfo.getTablePath();
         this.tableId = tableInfo.getTableId();
         this.isPartitionedTable = tableInfo.isPartitioned();
-        // addColumn this table to metadata updater.
+        // add this table to metadata updater.
         metadataUpdater.checkAndUpdateTableMetadata(Collections.singleton(tablePath));
         this.logScannerStatus = new LogScannerStatus();
         this.metadataUpdater = metadataUpdater;

fluss-client/src/main/java/org/apache/fluss/client/table/scanner/log/RemoteLogDownloader.java

@@ -108,7 +108,7 @@ public RemoteLogDownloader(
         this.prefetchSemaphore =
                 new Semaphore(conf.getInt(ConfigOptions.CLIENT_SCANNER_REMOTE_LOG_PREFETCH_NUM));
         // The local tmp dir to store the fetched log segment files,
-        // addColumn UUID to avoid conflict between tasks.
+        // add UUID to avoid conflict between tasks.
         this.localLogDir =
                 Paths.get(
                         conf.get(ConfigOptions.CLIENT_SCANNER_IO_TMP_DIR),
@@ -172,7 +172,7 @@ void fetchOnce() throws Exception {
                                             ExceptionUtils.stripExecutionException(throwable));
                                     // release the semaphore for the failed request
                                     prefetchSemaphore.release();
-                                    // addColumn back the request to the queue,
+                                    // add back the request to the queue,
                                     // so we do not complete the request.future here
                                     segmentsToFetch.add(request);
                                     scannerMetricGroup.remoteFetchErrorCount().inc();
@@ -191,7 +191,7 @@ void fetchOnce() throws Exception {
                             });
         } catch (Throwable t) {
             prefetchSemaphore.release();
-            // addColumn back the request to the queue
+            // add back the request to the queue
             segmentsToFetch.add(request);
             scannerMetricGroup.remoteFetchErrorCount().inc();
             // log the error and continue instead of shutdown the download thread

fluss-client/src/main/java/org/apache/fluss/client/utils/ClientRpcMessageUtils.java

@@ -361,7 +361,7 @@ public static PbAlterColumn toPbAlterColumn(TableChange tableChange) {
         PbAlterColumn pbAlterColumn = new PbAlterColumn();
         if (tableChange instanceof TableChange.AddColumn) {
             TableChange.AddColumn addColumn = (TableChange.AddColumn) tableChange;
-            // only support addColumn column at last now.
+            // only support add column at last now.
             if (addColumn.getPosition() != TableChange.ColumnPosition.last()) {
                 throw new IllegalArgumentException(
                         "Unsupported column position: " + addColumn.getPosition());