🐛 - checkboxes are synced across multiple days

[kriskbx]

Describe the bug
Toggling a checkbox causes checkboxes on other days to be toggled too.

To Reproduce
Steps to reproduce the behavior:

1. Add a checkbox to two consecutive days
2. Toggle it on day one
3. Switch to day two, it will be toggled there as well

Expected behavior
I expect the state of checkboxes to be isolated.

Screenshots

Desktop (please complete the following information):

• linked version: 1.1.8
• operating system: macOS 11.4

[lostdesign]

Oh what the hell.. that should not be lol. Gonna check wether this is regression or never worked before 🥴 thanks for the report.

[lostdesign]

So I checked out the bug and it seems to be visual only, it never persists to the file. A reload would show the right state of the checkbox. I do wonder how it affects other days though, this doesnt make much sense to me.

[lostdesign]

I have fixed it, despite not knowing what the reason was. The next version will create a new editor per day, which probably fixes it as the whole editor node is being refreshed.

Might investigate at some point.

[lostdesign]

this will be fixed in the version 1.4.0 release

[lostdesign]

Intended to fix this in 1.4.x but seems like the release did not end up as I originally expected. The issue still exists.

[abrahamalen]

@kriskbx issue still exists right?
Facing the same

OS: Ubuntu 22.04.1 LTS

[AlexHRodrii]

Me and my team want to fix it, we are going to start working locally

[mseiimeorn]

Hi hi,
don't ask me how I stumbled upon on that one - probably cause I was looking into building my own desktop application and I know lostdesign 😄 - but I'd have a fix for that one on a fork here, which I couldn't push on a branch in this repo:

master...mseiimeorn:linked:bugfix/#51

My fix would be, to add a key attribute to the tiptap implementation of the editor, so the ui of the editor gets refreshed on day change (or basically the tiptap editor in that version would get refreshed). I checked the DOM, and it didn't display the key attribute there.

Let me know what you think :)