bandgap double function mistake

Author: louisponet

Project.toml

@@ -2,7 +2,7 @@ name = "DFControl"
 uuid = "1e31e15d-4957-550d-a244-318eced754ae"
 authors = ["Louis Ponet <[email protected]>"]
 repo = "https://github.com/louisponet/DFControl.jl.git"
-version = "0.5.30"
+version = "0.5.31"
 
 [deps]
 ANSIColoredPrinters = "a4c015fc-c6ff-483c-b24f-f7ea428134e9"

src/types.jl

@@ -34,21 +34,6 @@ StructTypes.StructType(::Type{<:AbstractBand}) = StructTypes.Mutable()
     bandgap(bands::AbstractVector{Band}, n_electrons::Int)
     bandgap(bands::AbstractVector{Band}, fermi::Float64)
 
-Calculates the bandgap (possibly indirect) around the fermi level.
-"""
-function bandgap(bands::Union{Iterators.Flatten,AbstractVector{<:AbstractBand}},
-                 n_electrons::Int)
-    bands = sort(bands, by = x->maximum(eigvals(x)))
-    if length(bands) < n_electrons+1
-        error("not enough bands for $n_electrons electrons ($(length(bands)) bands)." )
-    end
-    gap = minimum(eigvals(bands[n_electrons+1])) - maximum(eigvals(bands[n_electrons]))
-    return gap < 0 ? 0.0 : gap
-end
-
-"""
-    bandgap(bands::AbstractVector{Band}, fermi=0.0)
-
 Calculates the bandgap (possibly indirect) around the fermi level.
 """
 function bandgap(bands::Union{Iterators.Flatten,AbstractVector{<:AbstractBand}},
@@ -63,7 +48,7 @@ function bandgap(bands::Union{Iterators.Flatten,AbstractVector{<:AbstractBand}},
 end
 
 function bandgap(bands::Union{Iterators.Flatten,AbstractVector{<:AbstractBand}},
-                 fermi = 0.0)
+                 fermi::Float64)
     max_valence = -Inf
     min_conduction = Inf
     for b in bands