Skip to content

Commit 4208e8f

Browse files
committed
test: Mark scheduler signal tests as expected to pass
With the scheduler signal handler fixed to by async-signal-safe, this test should now not be flaky and can be expected to consistently pass. Running pytest -k test_signal --count 100 -n auto gives 600/600 passes locally. Signed-off-by: Alex Jones <[email protected]>
1 parent 165b576 commit 4208e8f

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

tests/test_scheduler.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1011,12 +1011,6 @@ def _send_signals() -> None:
10111011
_assert_result_status(result, 3, expected=JobStatus.KILLED)
10121012

10131013
@staticmethod
1014-
@pytest.mark.xfail(
1015-
reason="This test passes ~95 percent of the time, but the logging & threading primitive"
1016-
"logic used in the signal handler are not async-signal-safe and thus may deadlock,"
1017-
"causing the process to hang and time out instead.",
1018-
strict=False,
1019-
)
10201014
@pytest.mark.parametrize("long_poll", [False, True])
10211015
@pytest.mark.parametrize(("sig", "repeat"), [(SIGTERM, False), (SIGINT, False), (SIGINT, True)])
10221016
def test_signal_kill(tmp_path: Path, *, sig: int, repeat: bool, long_poll: bool) -> None:

0 commit comments

Comments
 (0)