[cov,otbn] Add coverage_view for boot binary

This change adds a `coverage_view_test` target to the OTBN crypto BUILD
file for the `boot` binary. This allows for coverage
filtering of the boot code.

Change-Id: I4605a87677f1f198cadd34dbb5f65df5ed4332e8
Signed-off-by: Yi-Hsuan Deng <[email protected]>

Author: sasdf

sw/otbn/crypto/BUILD

@@ -3,6 +3,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 load("//rules:otbn.bzl", "otbn_binary", "otbn_library")
+load("//rules/coverage:view.bzl", "coverage_view_test")
 
 package(default_visibility = ["//visibility:public"])
 
@@ -19,6 +20,12 @@ otbn_binary(
     ],
 )
 
+coverage_view_test(
+    name = "boot_coverage_view",
+    elf = ":boot",
+    kind = "otbn",
+)
+
 otbn_library(
     name = "ed25519",
     srcs = [

util/coverage/collect_cc_coverage/generate_coverage_view.rs

@@ -218,7 +218,7 @@ fn find_executable_regions(
 /// across translation units may have a filename prefix separated by a colon.
 /// This function returns the base function name.
 fn dedup_inline_copies(name: &str) -> Result<&str> {
-    Ok(name.split(':').last().context("Invalid function name")?)
+    name.split(':').last().context("Invalid function name")
 }
 
 /// Filters raw LCOV output to only include regions that exist in the binary.
@@ -282,7 +282,7 @@ fn filter_lcov_view(
                 writeln!(filtered_lcov, "FN:{lineno},{name}")?;
             }
         }
-        for (name, _count) in &filtered.fnda {
+        for name in filtered.fnda.keys() {
             writeln!(filtered_lcov, "FNDA:0,{name}")?;
         }
         for lineno in &filtered.da {