Skip to content

Commit 6776896

Browse files
committed
[dv] Add more documentation to the sw_type_e
1 parent 64ac503 commit 6776896

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

hw/top_darjeeling/dv/env/chip_env_pkg.sv

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,10 @@ package chip_env_pkg;
102102
SpiDeviceIngressMem
103103
} chip_mem_e;
104104

105-
// On OpenTitan, we deal with 4 types of SW - ROM, the main test, the OTBN test and the OTP image.
105+
// On Darjeeling, we deal with 8 types of SW.
106106
// This basically puts these SW types into 'slots' that the external regression tool can set.
107+
// Note: This enum must be consistent across tops.
108+
// Note: If this enum is updated, then also update the file `build_sw_collateral_for_sim.py`.
107109
typedef enum {
108110
SwTypeRom = 0, // Ibex SW - first stage boot ROM.
109111
SwTypeTestSlotA = 1, // Ibex SW - test SW in (flash) slot A.

hw/top_earlgrey/dv/env/chip_env_pkg.sv

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,10 @@ package chip_env_pkg;
100100
Rom
101101
} chip_mem_e;
102102

103-
// On OpenTitan, we deal with 4 types of SW - ROM, the main test, the OTBN test and the OTP image.
103+
// On Earlgrey, we deal with 6 types of SW.
104104
// This basically puts these SW types into 'slots' that the external regression tool can set.
105+
// Note: This enum must be consistent across tops.
106+
// Note: If this enum is updated, then also update the file `build_sw_collateral_for_sim.py`.
105107
typedef enum {
106108
SwTypeRom = 0, // Ibex SW - first stage boot ROM.
107109
SwTypeTestSlotA = 1, // Ibex SW - test SW in (flash) slot A.

util/py/scripts/build_sw_collateral_for_sim.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
"dont_filter",
135135
]
136136

137-
137+
""" This enum should match the enum in `hw/top_<>/dv/env/chip_env_pkg.sv`. """
138138
class sw_type_e(Enum):
139139
SwTypeROM = 0 # Ibex SW - first stage boot ROM.
140140
SwTypeTestSlotA = 1 # Ibex SW - test SW in (flash) slot A.

0 commit comments

Comments
 (0)