Skip to content

Commit b6a5e5d

Browse files
committed
Stop terminating shackle pools on buoy app stop
buoy_app:stop/1 called shackle_pool:terminate(), which deletes the shackle_pool foil namespace while the shackle application is still running. shackle only rebuilds that namespace when its own supervisor starts, so any shackle_pool:start after a buoy restart in the same VM silently lost its foil entries and every request failed with pool_not_started. shackle_app:stop/1 already performs this cleanup when shackle itself stops.
1 parent ed7ec83 commit b6a5e5d

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

src/buoy_app.erl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,4 @@ start(_StartType, _StartArgs) ->
3636
ok.
3737

3838
stop(_State) ->
39-
shackle_pool:terminate(),
4039
ok.

0 commit comments

Comments
 (0)