Skip to content

Commit bcb122c

Browse files
committed
Correct the shackle_socket runtime floor to OTP 28
{otp, select_read} lands in OTP 28.0; on 27.3 the setopt returns {error, {invalid, {socket_option, {otp, select_read}}}}.
1 parent fce5fe7 commit bcb122c

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/shackle_socket.erl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22
-include("shackle_internal.hrl").
33

44
%% The socket specs on OTP < 28 predate {otp, select_read} and its
5-
%% recv return shapes, and socket:sendv only exists from OTP 27,
6-
%% although everything works at runtime from OTP 27.3.
5+
%% recv return shapes, and socket:sendv only exists from OTP 27.
6+
%% {otp, select_read} lands in OTP 28.0, so that is the runtime
7+
%% floor for this protocol.
78
-dialyzer({nowarn_function, [recv/1, send/2, sendv/2, setopts/2]}).
89
-ignore_xref([
910
{socket, sendv, 2}

0 commit comments

Comments
 (0)