Skip to content

Commit e7c7a9f

Browse files
committed
Revert "fix builder grow"
This reverts commit 80b1beb.
1 parent 80b1beb commit e7c7a9f

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

common.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,7 @@ func commaTables(scope scope, tables []Table) string {
9595
}
9696

9797
func commaValuesBuilder(scope scope, builder *strings.Builder, values []interface{}) error {
98-
if len(values) == 0 {
99-
return nil
100-
}
98+
builder.Grow(16 * (len(values) + 2)) // hopefully reduce copying
10199
for i, item := range values {
102100
if i > 0 {
103101
builder.WriteString(", ")

insert.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,11 @@ func (s insertStatus) GetSQL() (string, error) {
158158
if i > 0 {
159159
valuesBuilder.WriteString(", ")
160160
}
161-
valuesBuilder.WriteByte('(')
161+
valuesBuilder.WriteString("(")
162162
if err := commaValuesBuilder(s.scope, &valuesBuilder, model.GetValues()); err != nil {
163163
return "", err
164164
}
165-
valuesBuilder.WriteByte(')')
165+
valuesBuilder.WriteString(")")
166166
}
167167
}
168168
} else {

0 commit comments

Comments
 (0)