[support-o_nif_cc] Support o_nif_cc gpb_opt #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@lrascao Could you take a look a this change? Thanks!! |
elbrujohalcon
approved these changes
Feb 22, 2023
lrascao
reviewed
Feb 28, 2023
lrascao
reviewed
Feb 28, 2023
lrascao
reviewed
Feb 28, 2023
| proplists:get_value(o_hrl, GpbOpts0, | ||
| ?DEFAULT_OUT_HRL_DIR)]), | ||
| TargetNifDir = filename:join([AppOutDir, | ||
| proplists:get_value(o_nif_cc, GpbOpts0, |
Owner
There was a problem hiding this comment.
does this mean that people not interested in NIF generation will get it anyway?
Author
There was a problem hiding this comment.
Not really, by default the NIF generation would be off
Author
There was a problem hiding this comment.
What they would get is the priv folder. Maybe we shouldn't create that folder by default. What do you think @lrascao ?
Owner
There was a problem hiding this comment.
yeah, if it can be avoided that would be best, always good to avoid unexpected things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumbs the gpb version to the latest and adds support to the o_nif_cc option.