-
Notifications
You must be signed in to change notification settings - Fork 350
Open
Labels
assessmentPull requests that affect the corresponding modulePull requests that affect the corresponding modulebugchoreclientPull requests that update TypeScript code. (Added Automatically!)Pull requests that update TypeScript code. (Added Automatically!)exercisePull requests that affect the corresponding modulePull requests that affect the corresponding moduleplagiarismPull requests that affect the corresponding modulePull requests that affect the corresponding module
Description
Describe the bug
While migrating the client to the decoratorless Angular, certain issues with the CPC component while creating/updating exercises were discovered, see below.
To Reproduce
- Click on the button to create a new exercise or update an existing exercise
- Switch to advanced mode and Scroll down to enable continuous plagiarism
- Verify the documented behavior above
Expected behavior
- Similarity threshold increments in 5 but minimum score in 1, this should be made uniform across both fields.
- Minimum size field only goes up to 100 (e.g. no minimum size value >=101 can be set through the UI)
- The allowed min and max days for significant similarity response should be revised and validated again.
- It is currently possible to create an exercise with invalid values (e.g. negative similarity threshold) because the server does not validate the values, an appropriate error should be returned instead
Screenshots
No response
Which version of Artemis are you seeing the problem on?
8.2.3
What browsers are you seeing the problem on?
Firefox
Additional context
No response
Relevant log output
Metadata
Metadata
Assignees
Labels
assessmentPull requests that affect the corresponding modulePull requests that affect the corresponding modulebugchoreclientPull requests that update TypeScript code. (Added Automatically!)Pull requests that update TypeScript code. (Added Automatically!)exercisePull requests that affect the corresponding modulePull requests that affect the corresponding moduleplagiarismPull requests that affect the corresponding modulePull requests that affect the corresponding module