dont approve deployments on webhook events replay

Author: gbanu

server/application-server/src/main/java/de/tum/cit/aet/helios/deployment/github/GitHubDeploymentStatusMessageHandler.java

@@ -14,6 +14,7 @@
 import de.tum.cit.aet.helios.user.User;
 import de.tum.cit.aet.helios.user.github.GitHubUserSyncService;
 import java.io.IOException;
+import java.time.Instant;
 import java.util.Optional;
 import lombok.RequiredArgsConstructor;
 import lombok.extern.log4j.Log4j2;
@@ -41,6 +42,8 @@ public class GitHubDeploymentStatusMessageHandler
   private final GitHubFacade github;
   private final GitHubDataSyncOrchestrator gitHubDataSyncOrchestrator;
 
+  private final Instant applicationStartTime = Instant.now();
+
   @Override
   protected Class<GHEventPayload.DeploymentStatus> getPayloadClass() {
     return GHEventPayload.DeploymentStatus.class;
@@ -141,10 +144,21 @@ protected void handleInstalledRepositoryEvent(GHEventPayload.DeploymentStatus ev
     deploymentSyncService.processDeployment(
         deploymentSource, repository, environment, convertedUser);
 
-    // TODO: Don't approve deployment on data sync
+    // Auto-approve deployments in WAITING state
     if (deploymentSource.getState() == Deployment.State.WAITING) {
-      log.info("Deployment is in WAITING state. Reviewing the deployment.");
-      approvalService.reviewDeployment(deploymentSource, repository, environment, convertedUser);
+      // Check if this is a recent event (after app startup) or an old event being replayed
+      Instant eventTime;
+      try {
+        eventTime = eventPayload.getDeploymentStatus().getCreatedAt().toInstant();
+      } catch (IOException e) {
+        eventTime = Instant.now();
+      }
+
+      // Only automatically approve if the event is recent (after application startup)
+      if (eventTime.isAfter(applicationStartTime)) {
+        log.info("Recent deployment in WAITING state. Reviewing the deployment.");
+        approvalService.reviewDeployment(deploymentSource, repository, environment, convertedUser);
+      }
     }
   }
 }