Improve input validation, error handling, and workflow permissions #1508
dev.yml
on: pull_request
run-tests
/
build
3m 15s
run-e2e-tests
/
e2e
4m 27s
build-dev-container
/
build-server
2m 20s
build-dev-container
/
build-client
10m 29s
deploy-dev-container
/
deploy
Annotations
4 errors, 2 warnings, and 1 notice
|
build-dev-container / build-server
buildx failed with: ERROR: failed to build: failed to solve: process "/bin/sh -c ./gradlew build -x test --no-daemon" did not complete successfully: exit code: 1
|
|
[chromium] › e2e/navigation.spec.ts:57:7 › Navigation - Student routes › can navigate between pages via sidebar:
client/e2e/navigation.spec.ts#L73
2) [chromium] › e2e/navigation.spec.ts:57:7 › Navigation - Student routes › can navigate between pages via sidebar
Error: expect(locator).toBeVisible() failed
Locator: getByRole('heading', { name: /dashboard/i })
Expected: visible
Timeout: 15000ms
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 15000ms
- waiting for getByRole('heading', { name: /dashboard/i })
71 | await page.getByRole('link', { name: 'Dashboard' }).click()
72 | await expect(page).toHaveURL(/\/dashboard/)
> 73 | await expect(page.getByRole('heading', { name: /dashboard/i })).toBeVisible()
| ^
74 | })
75 |
76 | test('header logo navigates to dashboard when authenticated', async ({ page }) => {
at /home/runner/work/thesis-management/thesis-management/client/e2e/navigation.spec.ts:73:69
|
|
[chromium] › e2e/application-review-workflow.spec.ts:53:7 › Application Review Workflow › advisor can accept a NOT_ASSESSED application:
client/e2e/application-review-workflow.spec.ts#L57
1) [chromium] › e2e/application-review-workflow.spec.ts:53:7 › Application Review Workflow › advisor can accept a NOT_ASSESSED application
Error: expect(locator).toBeVisible() failed
Locator: getByRole('heading', { name: /Student5 User/i })
Expected: visible
Error: element(s) not found
Call log:
- Expect "toBeVisible" with timeout 30000ms
- waiting for getByRole('heading', { name: /Student5 User/i })
55 |
56 | // Wait for the page to fully load — the student heading is always visible for any state
> 57 | await expect(page.getByRole('heading', { name: /Student5 User/i })).toBeVisible({
| ^
58 | timeout: 30_000,
59 | })
60 |
at /home/runner/work/thesis-management/thesis-management/client/e2e/application-review-workflow.spec.ts:57:73
|
|
[chromium] › e2e/application-review-workflow.spec.ts:53:7 › Application Review Workflow › advisor can accept a NOT_ASSESSED application:
client/e2e/application-review-workflow.spec.ts#L0
1) [chromium] › e2e/application-review-workflow.spec.ts:53:7 › Application Review Workflow › advisor can accept a NOT_ASSESSED application
Test timeout of 60000ms exceeded.
|
|
The 'as' keyword should match the case of the 'from' keyword:
client.Dockerfile#L1
FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
|
|
Legacy key/value format with whitespace separator should not be used:
client.Dockerfile#L8
LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format
More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/
|
|
🎭 Playwright Run Summary
2 flaky
[chromium] › e2e/application-review-workflow.spec.ts:53:7 › Application Review Workflow › advisor can accept a NOT_ASSESSED application
[chromium] › e2e/navigation.spec.ts:57:7 › Navigation - Student routes › can navigate between pages via sidebar
70 passed (2.1m)
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
coverage-report
Expired
|
1010 KB |
sha256:60f5d0c184dfbe63dbe5ba609088c82ac67addab7d42e0e6edccd7df5aee86e0
|
|
|
ls1intum~thesis-management~5IDQ79.dockerbuild
|
99.5 KB |
sha256:456fc8669a93f74f77e0e5ca7bee1526369a3b6b12383adf101145001691bd03
|
|
|
ls1intum~thesis-management~85Y9BI.dockerbuild
|
30.8 KB |
sha256:567a20f9279160996ae839efcb7bc0f1c6c6be44c81dc7c889043d5c13e3c50a
|
|
|
playwright-report
Expired
|
2.56 MB |
sha256:27f95fce96eb4e4fa59b1daaeefd4e5be199b0358e026c3e5acc7eb237dc62cf
|
|
|
playwright-results
Expired
|
1.91 MB |
sha256:0c5d42dd51e0a9c32c62e2ca58ebf104c525fae0470625cf0ffed298a66eddfe
|
|
|
test-results
Expired
|
597 KB |
sha256:2af27e19d91fdc7a413b93b69307cbe0396476242883d56bfd797a5e1a0c692d
|
|