Commit 7e9e1d9
Address final review nits: log fetch errors and guard scheduledAt match
Two small polish items from the regression-risk review:
- ImprintPage / PrivacyPage: the prior .catch silently swallowed every
rejection. Now we ignore AbortError (intentional unmount cleanup) and
log other failures via console.warn so dev/operators still see real
network or sanitization problems.
- ReplacePresentationModal: when picking the newly-created presentation
from the response, the previous logic fell back to comparing
p.scheduledAt === null when the form's date was missing — which would
spuriously match an unrelated record with a null scheduledAt. The
form already validates date as required so this was practically
unreachable, but the new code guards explicitly: no match when no
date was submitted.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent f6b6313 commit 7e9e1d9
3 files changed
Lines changed: 15 additions & 11 deletions
File tree
- client/src
- components/PresentationsTable/components/ReplacePresentationModal
- pages
- ImprintPage
- PrivacyPage
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
129 | 135 | | |
130 | 136 | | |
131 | 137 | | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
139 | 141 | | |
140 | 142 | | |
141 | 143 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
20 | | - | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
| |||
0 commit comments