Skip to content

Commit 1c5c67d

Browse files
committed
fix(status): make reviewable a terminal unsuccessful script status
1 parent 7cd1fa9 commit 1c5c67d

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/lsst/cmservice/common/enums.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def is_successful_element(self) -> bool:
145145

146146
def is_successful_script(self) -> bool:
147147
"""Is this successful state for Script"""
148-
return self.value >= StatusEnum.reviewable.value
148+
return self.value >= StatusEnum.accepted.value
149149

150150
def is_bad(self) -> bool:
151151
"""Is this a failed state"""
@@ -166,6 +166,7 @@ def is_terminal_script(self) -> bool:
166166
[
167167
self.is_successful_script(),
168168
self.is_bad(),
169+
self is StatusEnum.reviewable,
169170
]
170171
)
171172

0 commit comments

Comments
 (0)