chore(tests):

- handle and reduce test warning feedback by ignoring known deprecations.
- fix meaningful test warnings
- upgrade pytest to 9.x and config to match

Author: tcjennings

packages/cm-models/pyproject.toml

@@ -14,7 +14,7 @@ dependencies = [
 
 [dependency-groups]
 dev = [
-    "pytest>=8.3.3",
+    "pytest>=9.0.0",
     "pytest-asyncio>=0.24.0",
     "pytest-cov>=6.0.0",
 ]

pyproject.toml

@@ -73,7 +73,7 @@ dev = [
     "json-schema-for-humans",
     "mypy>=1.17.0",
     "pre-commit>=4.5.1",
-    "pytest>=8.3.3",
+    "pytest>=9.0.0",
     "pytest-asyncio>=0.24.0",
     "pytest-cov>=6.0.0",
     "pytest-playwright>=0.5.2",
@@ -213,11 +213,17 @@ max-doc-length = 79
 [tool.ruff.lint.pydocstyle]
 convention = "numpy"
 
-[tool.pytest.ini_options]
-addopts = "--import-mode=importlib"
+[tool.pytest]
+minversion = "9.0"
+addopts = ["--import-mode=importlib"]
 asyncio_mode = "auto"
 asyncio_default_fixture_loop_scope="function"
 testpaths=["tests", "packages/**/*_tests"]
+filterwarnings= [
+    'ignore:(\n)?.*you probably want.*:DeprecationWarning',  # Ignore sqlmodel execute deprecation
+    'ignore:.*route_prefix.*:DeprecationWarning',  # Ignore asgi field deprecation
+    'ignore::DeprecationWarning:jinja2',
+]
 
 [tool.mypy]
 disallow_untyped_defs = true

src/lsst/cmservice/common/launchers.py

@@ -6,16 +6,15 @@
 from datetime import datetime
 from typing import Any
 
-from pydantic import BaseModel, Field, field_serializer
+from pydantic import BaseModel, ConfigDict, Field, field_serializer
 
 from lsst.cmservice.models.lib.timestamp import element_time
 
 
 class LauncherCheckResponse(BaseModel):
     """A model describing a response from a Launcher's check method."""
 
-    class Config:
-        validate_assignment = True
+    model_config = ConfigDict(validate_assignment=True)
 
     success: bool = Field(
         description="A boolean describing whether the check returned a successful result", default=False

src/lsst/cmservice/config.py

@@ -479,8 +479,10 @@ class AsgiConfiguration(BaseModel):
         description="The URL prefix used for API routers, i.e., a permanent subpath "
         "onto which the API routers are mounted. This should include a leading slash and no trailing slash.",
         default="",
-        deprecated=True,
-        examples=["cm-service"],
+        deprecated="`route_prefix` is deprecated. Use `root_path` instead, which will cause uvicorn to "
+        "rewrite any paths for the indicated reverse proxy/ingress path. For direct local access and tests, "
+        "use the API version directly and alone in the URI.",
+        examples=["/cm-service"],
     )
 
     root_path: str = Field(

tests/v2/test_machines.py

@@ -395,7 +395,7 @@ async def test_group_prepare_replace(
     # Assert the artifact path exists
     group_path = group.metadata_.get("artifact_path")
     assert group_path is not None
-    assert Path(group_path).exists()
+    assert await Path(group_path).exists()
 
     # Replace the group with a new version
     x = await aclient.patch(
@@ -433,7 +433,7 @@ async def test_group_prepare_replace(
     # group's path does not interfere
     group_path = group.metadata_.get("artifact_path")
     assert group_path is not None
-    assert Path(group_path).exists()
+    assert await Path(group_path).exists()
 
 
 async def test_group_fail_retry(
@@ -511,7 +511,7 @@ async def test_group_fail_retry(
         await group_machine.trigger("finish")
 
     # The artifact path should exist
-    assert Path(group_artifact_path).exists()
+    assert await Path(group_artifact_path).exists()
 
     await session.refresh(group, ["status"])
     group_status = group.status