feat(flags): Use feature flags in configs

- switch behaviors on feature flags instead of config params

Author: tcjennings

src/lsst/cmservice/config.py

@@ -17,6 +17,7 @@
 from pydantic_settings import BaseSettings, SettingsConfigDict
 
 from .common.enums import ScriptMethodEnum, StatusEnum, WmsComputeSite
+from .common.flags import EnabledFeatures
 
 __all__ = ["Configuration", "config"]
 
@@ -634,6 +635,7 @@ class Configuration(BaseSettings):
     slurm: SlurmConfiguration = SlurmConfiguration()
     panda: PandaConfiguration = PandaConfiguration()
     notifications: NotificationConfiguration = NotificationConfiguration()
+    features: EnabledFeatures = EnabledFeatures()
 
     # Root fields
     script_handler: ScriptMethodEnum = Field(

src/lsst/cmservice/main.py

@@ -8,6 +8,7 @@
 from safir.middleware.x_forwarded import XForwardedMiddleware
 
 from . import __version__
+from .common.flags import Features
 from .config import config
 from .db.session import db_session_dependency
 from .routers import (
@@ -53,11 +54,13 @@ async def lifespan(app: FastAPI) -> AsyncGenerator:
 
 app.include_router(healthz.health_router, prefix="")
 app.include_router(index.router, prefix="")
-app.include_router(v1.router, prefix=config.asgi.prefix)
-app.include_router(v2.router, prefix=config.asgi.prefix)
+if Features.API_V1 in config.features.enabled:
+    app.include_router(v1.router, prefix=config.asgi.prefix)
+if Features.API_V2 in config.features.enabled:
+    app.include_router(v2.router, prefix=config.asgi.prefix)
 
 # Start the frontend web application.
-if config.asgi.enable_frontend:
+if Features.WEBAPP_V1 in config.features.enabled:
     app.mount(config.asgi.frontend_prefix, web_app)
 
 

tests/v2/conftest.py

@@ -14,6 +14,7 @@
 from sqlalchemy.schema import CreateSchema, DropSchema
 from testcontainers.postgres import PostgresContainer
 
+from lsst.cmservice.common.flags import Features
 from lsst.cmservice.common.types import AnyAsyncSession
 from lsst.cmservice.config import config
 from lsst.cmservice.db.campaigns_v2 import metadata
@@ -38,6 +39,9 @@ def patched_config(monkeypatch_module: pytest.MonkeyPatch, tmp_path_factory: pyt
         target=config.bps, name="artifact_path", value=tmp_path_factory.mktemp("output")
     )
     monkeypatch_module.setattr(target=config.db, name="echo", value=False)
+    monkeypatch_module.setattr(
+        target=config.features, name="enabled", value=Features.API_V2 | Features.DAEMON_V2
+    )
 
 
 @pytest_asyncio.fixture(scope="module", loop_scope="module")