Skip to content

Commit fb342dc

Browse files
committed
chore: Address PR Feedback
- increase padding for node cards in campaign detail - refactor campaign overview grid with scrolling container
1 parent 748d443 commit fb342dc

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

packages/cm-web/src/lsst/cmservice/web/pages/campaign_detail.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ def create_node_card(self, node: dict) -> None:
6262
)
6363
)
6464
node_status = StatusDecorators[node["status"]]
65-
with ui.card().classes("pt-0 pb-0 pl-0 pr-2"):
65+
with ui.card().classes("p-2"):
6666
with ui.row():
6767
with ui.column().classes("items-center gap-2"):
6868
# Large hero avatar link
@@ -108,7 +108,7 @@ def create_node_card(self, node: dict) -> None:
108108
)
109109
newer_node_badge.move(node_version_chip)
110110

111-
with ui.card_actions().classes("w-full"):
111+
with ui.card_actions().classes("w-full p-0"):
112112
show_node_created_at = False
113113
if show_node_created_at and (node_created_at := node["metadata"].get("crtime")):
114114
ui.chip(

packages/cm-web/src/lsst/cmservice/web/pages/campaign_overview.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,10 @@ def campaign_card(self, campaign_id: str) -> None:
125125
@ui.refreshable_method
126126
def create_campaign_grid(self) -> None:
127127
"""Renders a grid of campaign cards."""
128-
with ui.grid(columns="auto 4fr"):
129-
for campaign in self.model["campaigns"]:
130-
self.campaign_card(campaign)
128+
with ui.element("div").classes("w-full h-full overflow-y-auto p-4"):
129+
with ui.element("div").classes("grid grid-cols-2 gap-4"):
130+
for campaign in self.model["campaigns"]:
131+
self.campaign_card(campaign)
131132

132133
@ui.refreshable_method
133134
async def create_content(self) -> None:

0 commit comments

Comments
 (0)