Spider shadows are optional

Author: jmeyers314

python/lsst/ts/wep/estimation/danish.py

@@ -56,17 +56,22 @@ class DanishAlgorithm(WfAlgorithm):
         Whether to jointly fit intra/extra pairs, when a pair is provided.
         If False, Zernikes are estimated for each individually, then
         averaged. (the default is True)
+    modelSpiderShadows: bool = False,
+        Whether to include the spider shadows or not in the danish forward
+        model.
     """
 
     def __init__(
         self,
         lstsqKwargs: dict | None = None,
         binning: int = 1,
         jointFitPair: bool = True,
+        modelSpiderShadows: bool = False,
     ) -> None:
         self.binning = binning
         self.lstsqKwargs = lstsqKwargs if lstsqKwargs is not None else {}
         self.jointFitPair = jointFitPair
+        self.modelSpiderShadows = modelSpiderShadows
         self.log = logging.getLogger(__name__)
 
     @property
@@ -603,9 +608,11 @@ def _estimateZk(
         dict
             Output from the danish algorithm to pass on as metadata.
         """
-        if rtp is not None:
+        if rtp is not None and self.modelSpiderShadows:
             rtp = rtp.wrap_at("180d").to_value("degree")
             self.log.info("Using RTP angle %s deg.", rtp)
+        else:
+            rtp = None
         # Create the Danish donut factory
         factory = danish.DonutFactory(
             R_outer=instrument.radius,

python/lsst/ts/wep/task/estimateZernikesDanishTask.py

@@ -50,6 +50,12 @@ class EstimateZernikesDanishConfig(EstimateZernikesBaseConfig):
         doc="Whether to jointly fit intra/extra pairs, when a pair is provided. "
         + "If False, Zernikes are estimated for each individually, then averaged. ",
     )
+    modelSpiderShadows: pexConfig.Field = pexConfig.Field(
+        dtype=bool,
+        default=False,
+        doc="Whether to include the spider shadows or not in the danish forward "
+        + "model."
+    )
 
 
 class EstimateZernikesDanishTask(EstimateZernikesBaseTask):