Fix all ESLint errors - add missing browser globals and fix code issues

Co-authored-by: lstein <111189+lstein@users.noreply.github.com>

Author: Copilot

eslint.config.js

@@ -31,10 +31,12 @@ export default [
         clearInterval: 'readonly',
         alert: 'readonly',
         confirm: 'readonly',
+        prompt: 'readonly',
         CustomEvent: 'readonly',
         Event: 'readonly',
         MouseEvent: 'readonly',
         KeyboardEvent: 'readonly',
+        TouchEvent: 'readonly',
         ResizeObserver: 'readonly',
         IntersectionObserver: 'readonly',
         MutationObserver: 'readonly',
@@ -43,8 +45,13 @@ export default [
         Node: 'readonly',
         NodeList: 'readonly',
         Blob: 'readonly',
+        File: 'readonly',
         FileReader: 'readonly',
         Image: 'readonly',
+        navigator: 'readonly',
+        performance: 'readonly',
+        requestAnimationFrame: 'readonly',
+        getComputedStyle: 'readonly',
         // Plotly global (used in umap.js)
         Plotly: 'readonly',
         // Swiper global (used in swiper.js)
@@ -91,6 +98,7 @@ export default [
         beforeAll: 'readonly',
         afterAll: 'readonly',
         jest: 'readonly',
+        global: 'readonly',
       },
     },
   },

photomap/frontend/static/javascript/events.js

@@ -130,7 +130,7 @@ window.addEventListener("slideshowStartRequested", async () => {
   if (state.gridViewActive) {
     await toggleGridSwiperView(false);
   }
-  await state.single_swiper.resetAllSlides(state.mode == "random");
+  await state.single_swiper.resetAllSlides(state.mode === "random");
   if (isUmapFullscreen()) {
     toggleUmapWindow(false);
   }
@@ -235,9 +235,9 @@ export async function toggleGridSwiperView(gridView = null) {
     gridContainer.style.display = "none";
     gridContainer.classList.remove("fade-out");
 
-    if (singleContainer.style.display == "none") // if previous hidden, then reset
+    if (singleContainer.style.display === "none") // if previous hidden, then reset
     {
-      await state.single_swiper.resetAllSlides(slideShowRunning && state.mode == "random");
+      await state.single_swiper.resetAllSlides(slideShowRunning && state.mode === "random");
     }
 
     // Fade in single view

photomap/frontend/static/javascript/search.js

@@ -16,10 +16,8 @@ export async function fetchImageByIndex(index) {
   const spinnerTimeout = setTimeout(() => showSpinner(), 500); // Show spinner after 0.5s
 
   try {
-    let url;
-
     // Album and index go into path
-    url = `retrieve_image/${encodeURIComponent(state.album)}/${encodeURIComponent(index)}`;
+    const url = `retrieve_image/${encodeURIComponent(state.album)}/${encodeURIComponent(index)}`;
 
     response = await fetch(url, {
       method: "GET",

photomap/frontend/static/javascript/swiper.js

@@ -380,7 +380,7 @@ class SwiperManager {
         searchIndex = null;
       }
       // Check for valid globalIndex and that it doesn't already exist
-      if (globalIndex != null && !existingIndices.has(globalIndex)) {
+      if (globalIndex !== null && !existingIndices.has(globalIndex)) {
         break;
       }
     }
@@ -579,7 +579,9 @@ class SwiperManager {
   }
 
   async seekToSlideIndex(event) {
-    let { globalIndex, searchIndex, totalCount, isSearchMode } = event.detail;
+    let { globalIndex, isSearchMode } = event.detail;
+    const searchIndex = event.detail.searchIndex;
+    const totalCount = event.detail.totalCount || slideState.totalAlbumImages;
 
     if (isSearchMode) {
       globalIndex = slideState.searchToGlobal(searchIndex);

photomap/frontend/static/javascript/umap.js

@@ -350,14 +350,6 @@ export async function fetchUmapData() {
         epsContainer.style.display = "block";
       }
 
-      // Add triangle trace and images after plot is created
-      if (landmarksVisible && typeof landmarkTrace !== "undefined") {
-        setTimeout(() => {
-          Plotly.addTraces(gd, [landmarkTrace]);
-          Plotly.relayout(gd, { images });
-        }, 500);
-      }
-
       // After adding traces (e.g., landmarks), move the marker trace to the end
       const plotDiv = document.getElementById("umapPlot");
       const markerTraceIndex = plotDiv.data.findIndex((trace) => trace.name === "Current Image");
@@ -432,7 +424,7 @@ export async function fetchUmapData() {
 function findLandmarkCluster(point) {
   const plotDiv = document.getElementById("umapPlot");
   const landmarkTraceIndex = plotDiv.data.findIndex((trace) => trace.name === "LandmarkClickTargets");
-  if (landmarkTraceIndex == -1) {
+  if (landmarkTraceIndex === -1) {
     return null;
   }
 
@@ -1267,7 +1259,9 @@ function proximityClusterOrder(clusterIndices, points, startIndex) {
 // Shared function for cluster clicks
 async function handleClusterClick(clickedIndex) {
   const clickedPoint = points.find((p) => p.index === clickedIndex);
-  if (!clickedPoint) return;
+  if (!clickedPoint) {
+    return;
+  }
 
   // Show spinner immediately to provide visual feedback
   showUmapSpinner();
@@ -1312,7 +1306,9 @@ async function handleClusterClick(clickedIndex) {
 // Handle single image selection (navigate to clicked image)
 async function handleImageClick(clickedIndex) {
   const clickedPoint = points.find((p) => p.index === clickedIndex);
-  if (!clickedPoint) return;
+  if (!clickedPoint) {
+    return;
+  }
 
   // Show spinner immediately to provide visual feedback
   showUmapSpinner();