Time sync implementation

[rot169]

I have a functional time sync here: https://github.com/rot169/zigbee_esphome/tree/timesync - see example_time.yml within.

I've not submitted a PR just yet as:

• I'm very new to esphome and I'd value a peer review
• I have a weird breaking bug I'm hoping someone can help squash... basicly if a zigbee component is defined but a time component is not defined, a build error occurs (fatal error: esphome/components/time/real_time_clock.h: No such file or directory). So long as some sort of time component is defined in the YML (regardless of if it's using zigbee as the platform, or somethign else) the build error disappears. I'm not sure how to convince esphome to always include real_time_clock.h in the build folder...? (To replicate the bug yourself, just comment-out all of the 'time' section, line 38 onwards in example_time.yml)

Thanks!

[luar123]

Thanks, that looks already good. Took a quick look only.
Some comments:

• I would prefer if you put everything in a time subfolder and rename time.py to __init__.py. This should also remove your build error. (Other wise you would need to wrap everything in #ifdef USE_TIME).
• Always use this-> for class attributes/methods
• I still need to look into the details, but for a basic implementation that should do.
• Not sure about the zigbee part, I don't think we have to add a server or client time cluster right? And maybe there are more attributes in the cluster that we could use.

[rot169]

Thanks for the steer. I'd tried the time subfolder initially but was struggling to get it working, and ran into the same issue again... but looks like it was a product of how I'd integrated the zigbee and time components togeteher with class pointers. Long story short, I've done a bit of refactoring and it's all good! PR submitted: #20

[rot169]

And nope, no additional zigbee clusters neeeded for this; time sync succesful as is. From the logs:

[19:58:44][D][zigbee:275][Zigbee_main]: Receive Zigbee Read Attribute response callback
[19:58:44][I][zigbee:247][Zigbee_main]: Recieved time information
[19:58:44][I][zigbee:028][Zigbee_main]: Read attribute response: status(0), attribute(0x0), type(0xe2), value(789940724)
[19:58:44][I][zigbee:038][Zigbee_main]: Recieved UTC time: 1736625524
[19:58:44][D][time:050][Zigbee_main]: Synchronized time: 2025-01-11 19:58:44
[19:58:44][D][main:188][Zigbee_main]: Synchronized system clock
[19:58:50][D][main:180]: Tick-tock, every 10 seconds
[19:59:00][D][main:180]: Tick-tock, every 10 seconds

[rot169]

Enum esp_zb_zcl_time_attr_t at the top of this file shows the additional time properties that could be requested. https://github.com/espressif/esp-zigbee-sdk/blob/c2d18360df0e0d26557a4816dc9342015c56dec2/components/esp-zigbee-lib/include/zcl/esp_zigbee_zcl_time.h

I don't think most would be that useful given the ESP32 seems to be fairly capable as-is managing time. Maybe a nice-to-have would be to try pulling the timezone reported by the coordinator and setting the device's timezone to match? But at the moment this can be specified manually in the 'time' config as shown in example_timesync.yml.