Description

Hi.

Today, I wanted a minimal proof that argparse is ready for Lua 5.5 by tracing what is failing in the test suite.

What's need?

Rockspec:
- Update dev rockspec (this PR needs to be merged rockspec: bump max lua version #33)
Dependencies:
- Code coverage:
  - luacov (this PR needs to be merged fix(lua55): loop variables are constants now lunarmodules/luacov#118)
  - cluacov (this PR needs to be merged support Lua 5.5 cluacov#7)
- Linting: luacheck (this PR needs to be merged fix(Lua 5.5): prevent change on control variable lunarmodules/luacheck#136)

Proof

I wrote a minimal CI reproduction to run argparse test suite (test + code coverage), applying all these patches:

Browse the runs: https://github.com/luau-project/ci-tests/actions/runs/21045391781

Click to toogle the workflow

name: Test

on: push

jobs:
  test:
    runs-on: ${{ matrix.os }}
    strategy:
      fail-fast: false
      matrix:
        luaVersion: ["5.1", "5.2", "5.3", "5.4", "5.5", "luajit", "luajit-openresty"]
        os: ["ubuntu-latest", "macos-latest", "windows-latest"]

    steps:
    # We are going to install
    # argparse from source
    # patched by https://github.com/luarocks/argparse/pull/33
    # to test argparse on Lua 5.5
    - uses: actions/checkout@master
      with:
        repository: luarocks/argparse

    - uses: ilammy/msvc-dev-cmd@v1
      if: ${{ runner.os == 'Windows' && !startsWith(matrix.luaVersion, 'luajit') }}

    - uses: luarocks/gh-actions-lua@master
      with:
        luaVersion: ${{ matrix.luaVersion }}

    - uses: luarocks/gh-actions-luarocks@master

    - name: Download argparse patch
      run: curl -kLO "https://github.com/luarocks/argparse/pull/33.patch"

    - name: Apply argparse patch
      run: git apply "33.patch"

    - name: Lint development rockspec
      run: luarocks lint "argparse-scm-2.rockspec"

    - name: Install the patched argparse
      run: luarocks make

    # We are going to install
    # luacov from source
    # patched by https://github.com/lunarmodules/luacov/pull/118
    # for the tests to pass on Lua 5.5
    - uses: actions/checkout@master
      with:
        repository: lunarmodules/luacov
        path: luacov-src

    - name: Download luacov patch
      working-directory: luacov-src
      run: curl -kLO "https://github.com/lunarmodules/luacov/pull/118.patch"

    - name: Apply luacov patch
      working-directory: luacov-src
      run: git apply "118.patch"

    - name: Install the patched luacov
      working-directory: luacov-src
      run: luarocks make

    # We are going to install
    # cluacov from source
    # patched by https://github.com/luarocks/cluacov/pull/7
    # for code coverage to pass on Lua 5.5
    - uses: actions/checkout@master
      with:
        repository: luarocks/cluacov
        path: cluacov-src

    - name: Download cluacov patch
      working-directory: cluacov-src
      run: curl -kLO "https://github.com/luarocks/cluacov/pull/7.patch"

    - name: Apply cluacov patch
      working-directory: cluacov-src
      run: git apply "7.patch"

    - name: Install the patched cluacov
      working-directory: cluacov-src
      run: luarocks make

    # We are going to install
    # luacheck from source
    # patched by https://github.com/lunarmodules/luacheck/pull/136
    # for linting to pass on Lua 5.5
    - uses: actions/checkout@master
      with:
        repository: lunarmodules/luacheck
        path: luacheck-src

    - name: Download luacheck patch
      working-directory: luacheck-src
      run: curl -kLO "https://github.com/lunarmodules/luacheck/pull/136.patch"

    - name: Apply luacheck patch
      working-directory: luacheck-src
      run: git apply "136.patch"

    - name: Install the patched luacheck
      working-directory: luacheck-src
      run: luarocks make

    - name: Install busted
      run: luarocks install busted

    - name: Run luacheck
      run: luacheck src spec

    - name: Run tests
      run: busted -c

    - name: Run code coverage
      run: luacov

Notes

Under these assumptions, I refactored argparse CI to use GitHub, and other minor edits to support Lua 5.5 at #34.

New release supporting Lua 5.5? #32

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions