bugfix: Lute tests on windows machines

Author: Vighnesh-V

.github/workflows/ci.yml

@@ -5,6 +5,7 @@ on:
     branches: ["primary"]
   pull_request:
     branches: ["primary"]
+  workflow_dispatch:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -43,7 +44,8 @@ jobs:
         run: rm .luaurc
 
       - name: Run Luau Tests
-        run: find tests -name "*.test.luau" | xargs -I {} ${{ steps.build_lute.outputs.exe_path }} run {}
+        shell: bash
+        run: find tests -name "*.test.luau" | xargs -I {} $(echo '${{ steps.build_lute.outputs.exe_path }}' | tr '\\' '/') run {}
 
   run-lute-cxx-unittests:
     runs-on: ${{ matrix.os }}

lute/std/libs/path/win32/init.luau

@@ -199,6 +199,7 @@ function win32.parse(path: pathlike): path
 		return setmetatable(path, path_mt)
 	end
 	if typeof(path) ~= "string" then
+	 print("Are we erroring in an uncaught way??")
 		error("Expected string or path")
 	end
 
@@ -273,7 +274,8 @@ function win32.resolve(...: pathlike): path
 	end
 
 	if not win32.isabsolute(path) then
-		local cwd = win32.parse(process.cwd())
+	 local cwd = win32.parse(process.cwd())
+	 print("-Nil?:", cwd, "-Nil?:", path, "-Nil?", joinHelper)
 		joinHelper(cwd, path)
 		path = cwd
 	end

tests/cli/compile.test.luau

@@ -23,8 +23,8 @@ local COMPILEE_CONTENTS = [[return "Hello world"]]
 local lutePath = process.execpath()
 local tmpDir = system.tmpdir()
 
-test.suite("Lute CLI Compile", function(suite)
-	suite:case("Run compile", function(check)
+test.suite("stdlib_compile", function(suite)
+	suite:case("run_in_script_bytecode_compilation", function(check)
 		-- Setup
 		-- Create files
 		local compilerPath = path.join(tmpDir, "compiler.luau")
@@ -39,8 +39,9 @@ test.suite("Lute CLI Compile", function(suite)
 
 		local result = process.run({ path.format(lutePath), path.format(compilerPath), path.format(compileePath) })
 		-- Compilation should work with no memory leaks
+		local expectedNewline = system.os == "Windows_NT" and "\r\n" or "\n"
 		check.eq(result.stderr, "")
-		check.eq(result.stdout, "SUCCESS\n")
+		check.eq(result.stdout, "SUCCESS" .. expectedNewline)
 		check.eq(result.exitcode, 0)
 
 		-- -- Cleanup

tests/cli/loadbypath.test.luau

@@ -43,7 +43,8 @@ test.suite("Lute CLI Run", function(suite)
 
 		local result = process.run({ tostring(lutePath), requirerPath, requireePath })
 		check.eq(result.exitcode, 0)
-		check.eq(result.stdout, "Success\n")
+		local expectedNewline = system.os == "Windows_NT" and "\r\n" or "\n"
+		check.eq(result.stdout, "Success" .. expectedNewline)
 
 		-- Cleanup
 		fs.remove(requirerPath)

tests/std/process.test.luau

@@ -1,6 +1,7 @@
 local pathlib = require("@std/path")
 local process = require("@std/process")
 local test = require("@std/test")
+local system = require("@std/system")
 
 test.suite("ProcessSuite", function(suite)
 	suite:case("homedir_and_cwd_and_execpath", function(assert)
@@ -19,7 +20,10 @@ test.suite("ProcessSuite", function(suite)
 		assert.eq(r.stdout, "hello-from-lute\n")
 	end)
 
-	suite:case("run_shell_and_cwd", function(assert)
+	suite:case("run_shell_and_cwd_posix", function(assert)
+		if system.win32 then
+			return
+		end
 		local r = process.run({ "pwd" }, { cwd = "/" })
 		assert.tableeq(r, {
 			exitcode = 0,
@@ -37,6 +41,55 @@ test.suite("ProcessSuite", function(suite)
 		})
 	end)
 
+	suite:case("run_shell_and_cwd_windows", function(assert)
+		if system.unix or system.macos or system.linux then
+			return
+		end
+		-- Get the current drive letter and construct root path
+		local cwd = process.cwd()
+		local cwdPath = pathlib.parse(cwd)
+		local driveLetter = cwdPath.driveLetter
+		local rootPath = driveLetter .. ":\\"
+
+		-- Git Bash on Windows converts C:\ to /c, D:\ to /d, etc.
+		local expectedOutput = "/" .. string.lower(driveLetter) .. "\n"
+
+		local r = process.run({ "pwd" }, { cwd = rootPath })
+		assert.tableeq(r, {
+			exitcode = 0,
+			stdout = expectedOutput,
+			stderr = "",
+			ok = true,
+		})
+
+		local r2 = process.run({ "echo hello!" }, { shell = true })
+		assert.tableeq(r2, {
+			exitcode = 0,
+			stdout = "hello!\r\n",
+			stderr = "",
+			ok = true,
+		})
+	end)
+
+	suite:case("run_with_cwd_tmpdir", function(assert)
+		-- Platform-independent test using tmpdir
+		local tmpdir = system.tmpdir()
+		local tmpdirStr = pathlib.format(tmpdir)
+
+		-- Use pwd/cd to verify cwd was changed correctly
+		local cmd = if system.win32 then { "cd" } else { "pwd" }
+		 local opts = if system.win32 then { cwd = tmpdirStr, shell = true } else { cwd = tmpdirStr }
+		  local lf = if system.win32 then "\r\n" else "\n"
+
+		local r = process.run(cmd, opts)
+		assert.eq(r.exitcode, 0)
+		assert.eq(r.ok, true)
+		assert.eq(r.stderr, "")
+		-- Normalize path separators and compare (remove trailing newline)
+		local actualPath = string.gsub(r.stdout, lf .. "$", "")
+		assert.eq(actualPath, tmpdirStr)
+	end)
+
 	suite:case("run_nonzero_exitcode", function(assert)
 		local r = process.run({ "sh", "-c", "exit 41" })
 		assert.tableeq(r, {