foreach

Author: skberkeley

lute/std/libs/syntax/query.luau

@@ -13,7 +13,8 @@ export type query<T = node> = {
 	nodes: { T },
 	filter: (self: query<T>, pred: (T) -> boolean) -> query<T>,
 	replace: (self: query<T>, repl: (T) -> types.replacement?) -> types.replacements,
-	map: <U>(self: query<T>, fn: (T) -> (U | { U })?) -> query<U>,
+	map: <U>(self: query<T>, fn: (T) -> (U | { U })?) -> query<U>, -- recursion violation reported
+	forEach: (self: query<T>, callback: (T) -> ()) -> (),
 }
 
 local queryLib = {}
@@ -54,7 +55,13 @@ function queryLib.map<T, U>(self: query<T>, fn: (T) -> (U | { U })?): query<U>
 			end
 		end
 	end
-	return { nodes = newNodes, filter = self.filter, replace = self.replace, map = self.map }
+	return { nodes = newNodes, filter = self.filter, replace = self.replace, map = self.map, forEach = self.forEach }
+end
+
+function queryLib.forEach<T>(self: query<T>, callback: (T) -> ()): ()
+	for _, node in self.nodes do
+		callback(node)
+	end
 end
 
 function queryLib.select<T>(ast: node, fn: (node) -> (T | { T })?): query<T>
@@ -156,7 +163,13 @@ function queryLib.select<T>(ast: node, fn: (node) -> (T | { T })?): query<T>
 		error("Unsupported node kind: " .. tostring(nodeKind))
 	end
 
-	return { nodes = nodes, filter = queryLib.filter, replace = queryLib.replace, map = queryLib.map } -- LUAUFIX: queryLib.map has generics quantified at a different level than expected
+	return {
+		nodes = nodes,
+		filter = queryLib.filter,
+		replace = queryLib.replace,
+		map = queryLib.map,
+		forEach = queryLib.forEach,
+	} -- LUAUFIX: queryLib.map has generics quantified at a different level than expected
 end
 
 return table.freeze(queryLib)

tests/syntax/query.test.luau

@@ -9,6 +9,7 @@ local function mockQuery<T>(nodes: { T }): query.query<T>
 		nodes = nodes,
 		filter = query.filter,
 		replace = query.replace,
+		forEach = query.forEach,
 		map = query.map, -- LUAUFIX: should this subtype?
 	}
 end
@@ -88,6 +89,21 @@ test.suite("AST Query", function(suite)
 		assert.eq(mappedQuery.nodes[3], 40)
 	end)
 
+	suite:case("forEach", function(assert)
+		local testQuery = mockQuery({
+			parser.parseexpr("0") :: luau.AstExprConstantNumber,
+			parser.parseexpr("1") :: luau.AstExprConstantNumber,
+			parser.parseexpr("2") :: luau.AstExprConstantNumber,
+		})
+
+		local sum = 0
+		testQuery:forEach(function(n: luau.AstExprConstantNumber)
+			sum = sum + n.value
+		end)
+
+		assert.eq(sum, 3) -- 0 + 1 + 2 = 3
+	end)
+
 	suite:case("select_nums", function(assert)
 		local ast = luau.parse("print(1 + 2)")
 		local queryResult: query.query<luau.AstExprConstantNumber> = query.select(