Improvements via Copilot review

Author: Nagesh Pai

assets/infotip/infotip-web-component.js

@@ -193,7 +193,7 @@ class BlaBlaBlocksInfotip extends HTMLElement {
 							clip-rule="evenodd"
 						/>`,
 		};
-		return `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24">
+		return `<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" aria-hidden="true" role="img">
 				${ iconPaths[ iconType ] }
 				</svg>`;
 	}
@@ -206,7 +206,7 @@ class BlaBlaBlocksInfotip extends HTMLElement {
 				${ this.renderStyle() }
 			</style>
 			<span class="wrapper">
-			<span class="text" tabindex="0" aria-describedby="infotip-popover">
+			<span class="text" tabindex="0" role="button" aria-describedby="infotip-popover">
 			<span class="icon"></span>
 			<slot></slot>
 				</span>

src/infotip/inline-ui.js

@@ -27,6 +27,7 @@ import {
 	info,
 	notAllowed,
 	starEmpty,
+	update,
 } from '@wordpress/icons';
 import { PanelColorSettings } from '@wordpress/block-editor';
 import { useSelect } from '@wordpress/data';
@@ -202,7 +203,9 @@ function IconTabContent( {
 
 	// Show the info icon enabled as a default when no icon type is set, and icons are just enabled.
 	if ( iconEnabled && ! activeAttributes[ 'icon-type' ] ) {
-		activeAttributes[ 'icon-type' ] = 'info';
+		updateAttributes( {
+			'icon-type': 'info',
+		} );
 	}
 
 	return (
@@ -222,7 +225,7 @@ function IconTabContent( {
 						<Button
 							accessibleWhenDisabled={ true }
 							disabled={ ! iconEnabled }
-							key={ icon.label }
+							key={ icon.id }
 							icon={ icon.graphic }
 							isPressed={
 								activeAttributes[ 'icon-type' ] === icon.id