chore: fix ci (#1)

* try fix

* use unstable

* log errors

* proc.stderrOutput

* fix

* dont fail-fast

* dont chmod on windows

* logging

* dont log ws errors

* headless

* disable macos

Author: lucacasonato

.github/workflows/ci.yml

@@ -14,19 +14,20 @@ jobs:
     strategy:
       matrix:
         deno: ["v1.x", "nightly"]
-        os: [macOS-latest, windows-latest, ubuntu-latest]
+        os: [windows-latest, ubuntu-latest] # Can't run on macOS because headless isn't working there.
+      fail-fast: false
 
     steps:
       - name: Setup repo
         uses: actions/checkout@v2
 
       - name: Setup Deno
-        uses: denolib/setup-deno@v2.3
+        uses: denolib/setup-deno@v2.3.0
         with:
           deno-version: ${{ matrix.deno }}
 
       - name: Cache Dependencies
-        run: deno cache mod.ts
+        run: deno cache --unstable mod.ts
 
       - name: Install Chromium
         run: deno run -A --unstable install.ts

tests.ts

@@ -11,7 +11,9 @@ function browserTest(
   Deno.test(name, async () => {
     let browser: Browser | undefined = undefined;
     try {
-      browser = await puppeteer.launch();
+      browser = await puppeteer.launch({
+        headless: true,
+      });
       await fn(browser);
     } finally {
       if (browser) await browser.close();

vendor/puppeteer-core/puppeteer/common/BrowserWebSocketTransport.js

@@ -13,7 +13,11 @@ export class BrowserWebSocketTransport {
       }
     });
     // Silently ignore all errors - we don't know what to do with them.
-    this._ws.addEventListener("error", () => {});
+    this._ws.addEventListener(
+      "error",
+      () => {},
+      // (err) => console.log("BrowserWebSocketTransport error:", err),
+    );
     this.onmessage = null;
     this.onclose = null;
   }

vendor/puppeteer-core/puppeteer/deno/BrowserFetcher.ts

@@ -286,7 +286,8 @@ export class BrowserFetcher {
         await Deno.remove(archivePath, { recursive: true });
     }
     const revisionInfo = this.revisionInfo(revision);
-    if (revisionInfo) await Deno.chmod(revisionInfo.executablePath, 0o755);
+    if (revisionInfo && Deno.build.os !== "windows")
+      await Deno.chmod(revisionInfo.executablePath, 0o755);
     return revisionInfo;
   }
 

vendor/puppeteer-core/puppeteer/deno/BrowserRunner.ts

@@ -70,6 +70,10 @@ export class BrowserRunner {
       this._closed = true;
       try {
         if (this.proc) {
+          if (!status.success) {
+            await Deno.copy(this.proc.stdout!, Deno.stdout);
+            await Deno.copy(this.proc.stderr!, Deno.stderr);
+          }
           this.proc.stdin!.close();
           this.proc.stdout!.close();
           this.proc.stderr!.close();
@@ -141,6 +145,8 @@ export class BrowserRunner {
       timeout,
       preferredRevision
     );
+    Deno.copy(this.proc!.stdout!, Deno.stdout);
+    Deno.copy(this.proc!.stderr!, Deno.stderr);
     const transport = await BrowserWebSocketTransport.create(browserWSEndpoint);
     this.connection = new Connection(browserWSEndpoint, transport, slowMo);
     return this.connection;