Non try/catchable TimeoutError

[devingfx]

Hi !

I found a weird bug : this error, that occurs in a timeout is not catchable with a try/catch clause around puppeteer.launch.

let browser
try {
    browser = await puppeteer.launch({ ...opts })
}
catch(e)
{
    browser = await puppeteer.connect({ ...ws })
}

deno-puppeteer/src/deno/BrowserRunner.ts

Lines 163 to 165 in 45b3162

	throw new TimeoutError(
	`Timed out after ${timeout} ms while trying to connect to the browser! Only Chrome at revision r${preferredRevision} is guaranteed to work.`,
	);

This occurs while trying to launch a browser / user-data-dir couple a second time, chrome won't open a new instance but instead open a new page on the existing browser instance, and though don't output to stdout the ws endpoint as usual...
The try / catch in fact work as expected, and connects to the instance instead in this case, but the sub task (out of scope) launch that failed will crash the process after 30s timeout not connecting... even if it was expicitely used in a try clause...

[devingfx]

I try the other way around:
Try to connect ws 1st and then if fail use launch... This work. But another problem pop up: as I want to open not headless windows with no ui with the commandline argument --app= I need to call puppeteer.launch for that, as nor puppeteer nor CDP are able to open this kind of window.

So I finished to use launch still even when after a connect, what work quite well! I can open several times the same exe/user-dir/window/page without UI, but only for 30s 😭 then still this TimeoutError crashes the process !

[devingfx]

The catched error is from readline:

deno-puppeteer/src/deno/BrowserRunner.ts

Line 168 in 45b3162

for await (const line of readLines(browserProcess.stderr!)) {

you may need to try/catch readline (that fail because the executable doesn't output anything while executed a 2nd time with same user-data-dir ) to be able to clearTimeout(timeId) and rethrow ...

[devingfx]

I even tried to augment the timeout, but there is a 24 days limit due to int32, a delay that is not suitable for server side applications that should be up for days...