Release v2.5.1: fix GetAppClusteringInfo counter accounting

Patch release bundling the counter-accounting fix. Dashboards using
ovn_successful_requests_total / ovn_requests_total as a success-rate
expression previously capped at ~93% even when nothing was failing;
they now report 100% when the cluster is healthy.

- Bump VERSION to 2.5.1.
- Bump README download URLs to v2.5.1.
- Add a What's New in v2.5.1 section.
- Fix inverted thresholds on two SLA panels in ovn-sla-performance:
  * SLA Compliance Over Time had base=transparent (hiding dips below
    99%); flipped to base=red, 99=yellow, 99.9=green.
  * OVN Control Plane Reachability defaults had base=green, 80=red
    (inverted); flipped to base=red, 95=yellow, 99=green.

Signed-off-by: Michele Palazzi <sysdadmin@m1k.cloud>

Author: ironashram

README.md

@@ -17,6 +17,11 @@ This exporter collects metrics from the following OVN components:
 * `OVN Southbound` database
 * `Open_vSwitch` database
 
+## What's New in v2.5.1
+
+### Bug Fixes
+- **Fix request counter accounting.** `GetAppClusteringInfo()` used `IncrementRequestCounter()` on both branches instead of the success/error variants, so `ovn_requests_total` drifted above `ovn_successful_requests_total + ovn_failed_requests_total`. Dashboards computing `ovn_successful_requests_total / ovn_requests_total` saw an artificial ceiling below 100% even when nothing was actually failing.
+
 ## What's New in v2.5.0
 
 ### Breaking Changes
@@ -80,13 +85,13 @@ Download the latest release for your platform from the [releases page](https://g
 
 ```bash
 # Linux amd64
-wget https://github.com/Liquescent-Development/ovn_exporter/releases/download/v2.5.0/ovn-exporter_2.5.0_linux_amd64.tar.gz
-tar xvzf ovn-exporter_2.5.0_linux_amd64.tar.gz
+wget https://github.com/Liquescent-Development/ovn_exporter/releases/download/v2.5.1/ovn-exporter_2.5.1_linux_amd64.tar.gz
+tar xvzf ovn-exporter_2.5.1_linux_amd64.tar.gz
 sudo mv ovn-exporter /usr/local/bin/
 
 # Linux arm64
-wget https://github.com/Liquescent-Development/ovn_exporter/releases/download/v2.5.0/ovn-exporter_2.5.0_linux_arm64.tar.gz
-tar xvzf ovn-exporter_2.5.0_linux_arm64.tar.gz
+wget https://github.com/Liquescent-Development/ovn_exporter/releases/download/v2.5.1/ovn-exporter_2.5.1_linux_arm64.tar.gz
+tar xvzf ovn-exporter_2.5.1_linux_arm64.tar.gz
 sudo mv ovn-exporter /usr/local/bin/
 ```
 

VERSION

@@ -1 +1 @@
-2.5.0
+2.5.1

dashboards/ovn-sla-performance.json

@@ -606,11 +606,11 @@
             "mode": "absolute",
             "steps": [
               {
-                "color": "transparent",
-                "value": 0
+                "color": "red",
+                "value": null
               },
               {
-                "color": "red",
+                "color": "yellow",
                 "value": 99
               },
               {
@@ -800,12 +800,16 @@
             "mode": "absolute",
             "steps": [
               {
-                "color": "green",
-                "value": 0
+                "color": "red",
+                "value": null
               },
               {
-                "color": "red",
-                "value": 80
+                "color": "yellow",
+                "value": 95
+              },
+              {
+                "color": "green",
+                "value": 99
               }
             ]
           }