fix: typo + deletion endpoint + uppercase validation

Author: lucas-guerin-44

src/core/datalake.py

@@ -621,6 +621,73 @@ def get_data_range(instrument: str, timeframe: str) -> Optional[dict]:
     return None
 
 
+def delete_ohlc_data(
+    instrument: str,
+    timeframe: Optional[str] = None,
+    start=None,
+    end=None,
+) -> int:
+    """
+    Delete rows from ohlc_data matching instrument [+ timeframe] [+ window).
+    Window is half-open [start, end). Returns rows deleted.
+    """
+    instrument = validate_instrument(instrument)
+    if timeframe is not None:
+        timeframe = validate_timeframe(timeframe)
+
+    clauses = ["instrument = ?"]
+    params: list = [instrument]
+    if timeframe is not None:
+        clauses.append("timeframe = ?")
+        params.append(timeframe)
+    if start is not None:
+        clauses.append("timestamp >= ?")
+        params.append(pd.Timestamp(start).tz_localize(None) if pd.Timestamp(start).tz is None else pd.Timestamp(start).tz_convert("UTC").tz_localize(None))
+    if end is not None:
+        clauses.append("timestamp < ?")
+        params.append(pd.Timestamp(end).tz_localize(None) if pd.Timestamp(end).tz is None else pd.Timestamp(end).tz_convert("UTC").tz_localize(None))
+    where = " AND ".join(clauses)
+
+    with _write_tx_lock:
+        con = _get_shared_connection()
+        before = con.execute(f"SELECT COUNT(*) FROM ohlc_data WHERE {where}", params).fetchone()[0]
+        con.execute(f"DELETE FROM ohlc_data WHERE {where}", params)
+
+    logger.info("Deleted OHLC rows", extra={
+        "instrument": instrument, "timeframe": timeframe,
+        "start": str(start) if start else None, "end": str(end) if end else None,
+        "rows": before,
+    })
+    return before
+
+
+def delete_tick_data(instrument: str, start=None, end=None) -> int:
+    """Delete rows from tick_data matching instrument [+ window). Returns rows deleted."""
+    instrument = validate_instrument(instrument)
+
+    clauses = ["instrument = ?"]
+    params: list = [instrument]
+    if start is not None:
+        clauses.append("timestamp >= ?")
+        params.append(pd.Timestamp(start).tz_localize(None) if pd.Timestamp(start).tz is None else pd.Timestamp(start).tz_convert("UTC").tz_localize(None))
+    if end is not None:
+        clauses.append("timestamp < ?")
+        params.append(pd.Timestamp(end).tz_localize(None) if pd.Timestamp(end).tz is None else pd.Timestamp(end).tz_convert("UTC").tz_localize(None))
+    where = " AND ".join(clauses)
+
+    with _write_tx_lock:
+        con = _get_shared_connection()
+        before = con.execute(f"SELECT COUNT(*) FROM tick_data WHERE {where}", params).fetchone()[0]
+        con.execute(f"DELETE FROM tick_data WHERE {where}", params)
+
+    logger.info("Deleted tick rows", extra={
+        "instrument": instrument,
+        "start": str(start) if start else None, "end": str(end) if end else None,
+        "rows": before,
+    })
+    return before
+
+
 def get_database_stats() -> dict:
     """Get overall database statistics."""
     with get_db_connection() as con:

src/routes/instruments.py

@@ -1,12 +1,21 @@
 """Instruments routes - list instruments and timeframes from DuckDB."""
+from datetime import datetime
 from typing import Optional
 
 from fastapi import APIRouter, Depends, Query, HTTPException
 
 from src.config import ALLOW_PUBLIC_READS
 from src.core.database import User
-from src.core.datalake import list_instruments, list_timeframes, get_data_range, list_tick_instruments, get_tick_coverage
-from src.services.validators import validate_instrument
+from src.core.datalake import (
+    list_instruments,
+    list_timeframes,
+    get_data_range,
+    list_tick_instruments,
+    get_tick_coverage,
+    delete_ohlc_data,
+    delete_tick_data,
+)
+from src.services.validators import validate_instrument, validate_timeframe
 from src.auth.auth import ScopedAuth
 
 router = APIRouter()
@@ -62,6 +71,53 @@ def get_instrument_detail(
     return {"symbol": symbol, "timeframes": coverage}
 
 
+@router.delete("/instruments/{symbol}")
+def delete_instrument_data(
+    symbol: str,
+    timeframe: Optional[str] = Query(None, description="If set, only delete this timeframe (or 'TICK' for ticks)."),
+    start: Optional[datetime] = Query(None, description="Half-open window start (UTC). Inclusive."),
+    end: Optional[datetime] = Query(None, description="Half-open window end (UTC). Exclusive."),
+    include_ticks: bool = Query(True, description="Also delete tick_data when timeframe is unset."),
+    confirm: bool = Query(False, description="Must be true — guard against accidental DELETE."),
+    current_user: User = Depends(ScopedAuth("admin")),
+):
+    """
+    Delete OHLC and/or tick rows for a symbol. Admin-only.
+
+    - No `timeframe`: wipes every OHLC timeframe for the symbol; also wipes ticks
+      unless `include_ticks=false`.
+    - `timeframe=TICK`: only ticks.
+    - `timeframe=M1` (etc): only that OHLC timeframe.
+    - `start`/`end` scope by window; omit for full range.
+    """
+    if not confirm:
+        raise HTTPException(status_code=400, detail="Pass confirm=true to actually delete.")
+
+    symbol = validate_instrument(symbol)
+
+    deleted = {}
+    if timeframe is None:
+        deleted["ohlc"] = delete_ohlc_data(symbol, start=start, end=end)
+        if include_ticks:
+            deleted["ticks"] = delete_tick_data(symbol, start=start, end=end)
+    elif timeframe.upper() == "TICK":
+        deleted["ticks"] = delete_tick_data(symbol, start=start, end=end)
+    else:
+        tf = validate_timeframe(timeframe)
+        deleted["ohlc"] = delete_ohlc_data(symbol, timeframe=tf, start=start, end=end)
+
+    return {
+        "status": "ok",
+        "symbol": symbol,
+        "timeframe": timeframe,
+        "window": {
+            "start": start.isoformat() if start else None,
+            "end": end.isoformat() if end else None,
+        },
+        "deleted": deleted,
+    }
+
+
 @router.get("/timeframes")
 def get_timeframes(
     instrument: str | None = Query(None),

src/services/validators.py

@@ -37,7 +37,7 @@ def validate_instrument(instrument: str) -> str:
             detail="Invalid instrument name: must contain only alphanumeric characters, underscores, hyphens, and ampersands"
         )
 
-    return instrument
+    return instrument.upper()
 
 
 def validate_timeframe(timeframe: str) -> str:

web/src/pages/index.astro

@@ -26,7 +26,7 @@ const year = new Date().getFullYear();
         Since 2025.
       </div>
       <div class="flex items-center gap-6">
-        <a href="https://github.com/lucasguerin/datalake-api" target="_blank" rel="noopener" class="hover:text-ink-200 transition-colors">GitHub</a>
+        <a href="https://github.com/lucas-guerin-44/datalake-api" target="_blank" rel="noopener" class="hover:text-ink-200 transition-colors">GitHub</a>
         <a href="mailto:guerin.lucas44@gmail.com" class="hover:text-ink-200 transition-colors">guerin.lucas44@gmail.com</a>
       </div>
     </div>