Skip to content

Commit 45ad60c

Browse files
committed
Minor improvements and fixes
1 parent 97d7871 commit 45ad60c

File tree

28 files changed

+119
-67
lines changed

28 files changed

+119
-67
lines changed

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/MainActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import androidx.compose.runtime.Composable
55
import androidx.compose.runtime.getValue
66
import br.com.dillmann.fireflycompanion.android.core.activity.PreconfiguredActivity
77
import br.com.dillmann.fireflycompanion.android.core.compose.persistent
8-
import br.com.dillmann.fireflycompanion.android.core.koin.KoinManager.koin
8+
import br.com.dillmann.fireflycompanion.android.core.koin.get
99
import br.com.dillmann.fireflycompanion.android.core.router.Route
1010
import br.com.dillmann.fireflycompanion.android.core.router.Router
1111
import br.com.dillmann.fireflycompanion.business.serverconfig.usecase.GetConfigUseCase
@@ -14,7 +14,7 @@ class MainActivity : PreconfiguredActivity() {
1414
@Composable
1515
override fun Content(padding: PaddingValues) {
1616
val initialRoute by persistent {
17-
val serverConfig = koin().get<GetConfigUseCase>().getConfig()
17+
val serverConfig = get<GetConfigUseCase>().getConfig()
1818
if (serverConfig == null)
1919
Route.ONBOARDING_START_SCREEN
2020
else

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/accounts/AccountForm.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@ import br.com.dillmann.fireflycompanion.android.core.refresh.OnRefreshEvent
2323
import br.com.dillmann.fireflycompanion.android.core.refresh.RefreshDispatcher
2424
import br.com.dillmann.fireflycompanion.android.core.router.NavigationContext
2525
import br.com.dillmann.fireflycompanion.android.core.components.textfield.AppTextFieldDefaults
26+
import br.com.dillmann.fireflycompanion.android.core.koin.get
2627
import br.com.dillmann.fireflycompanion.business.account.Account
2728
import br.com.dillmann.fireflycompanion.business.account.usecase.GetAccountUseCase
2829
import br.com.dillmann.fireflycompanion.business.account.usecase.UpdateAccountBalanceUseCase
2930
import br.com.dillmann.fireflycompanion.business.transaction.usecase.ListTransactionsUseCase
30-
import org.koin.java.KoinJavaComponent.getKoin
3131

3232
@Composable
3333
@OptIn(ExperimentalMaterial3Api::class)
@@ -36,9 +36,9 @@ fun NavigationContext.AccountForm() {
3636
var account by volatile(requireBagValue<Account>())
3737
var balance by volatile(account.currentBalance)
3838
var showLoading by volatile(false)
39-
val listTransactionsUseCase = getKoin().get<ListTransactionsUseCase>()
40-
val updateBalanceUseCase = getKoin().get<UpdateAccountBalanceUseCase>()
41-
val getAccountUseCase = getKoin().get<GetAccountUseCase>()
39+
val listTransactionsUseCase = get<ListTransactionsUseCase>()
40+
val updateBalanceUseCase = get<UpdateAccountBalanceUseCase>()
41+
val getAccountUseCase = get<GetAccountUseCase>()
4242

4343
fun updateBalance() {
4444
showLoading = true

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/biometric/Biometrics.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import android.os.CancellationSignal
77
import br.com.dillmann.fireflycompanion.android.R
88
import br.com.dillmann.fireflycompanion.android.core.compose.async
99
import br.com.dillmann.fireflycompanion.android.core.i18n.i18n
10+
import br.com.dillmann.fireflycompanion.android.core.koin.get
1011
import br.com.dillmann.fireflycompanion.business.preferences.usecase.GetPreferencesUseCase
11-
import org.koin.java.KoinJavaComponent.getKoin
1212
import java.time.LocalDateTime
1313
import java.util.concurrent.Executors
1414

@@ -52,7 +52,7 @@ object Biometrics {
5252
if (lockedAt == null)
5353
return false
5454

55-
val preferences = async { getKoin().get<GetPreferencesUseCase>().getPreferences() }.get()
55+
val preferences = async { get<GetPreferencesUseCase>().getPreferences() }.get()
5656
val skewSeconds = preferences.lockTimeout.seconds
5757

5858
return lockedAt!!.plusSeconds(skewSeconds) > LocalDateTime.now()

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/core/activity/PreconfiguredActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import br.com.dillmann.fireflycompanion.android.biometric.BiometricUnlockActivit
1919
import br.com.dillmann.fireflycompanion.android.biometric.Biometrics
2020
import br.com.dillmann.fireflycompanion.android.core.compose.async
2121
import br.com.dillmann.fireflycompanion.android.core.context.AppContext
22-
import br.com.dillmann.fireflycompanion.android.core.koin.KoinManager.koin
22+
import br.com.dillmann.fireflycompanion.android.core.koin.get
2323
import br.com.dillmann.fireflycompanion.android.core.theme.AppTheme
2424
import br.com.dillmann.fireflycompanion.android.core.theme.AppThemeContext
2525
import br.com.dillmann.fireflycompanion.business.preferences.Preferences
@@ -90,7 +90,7 @@ abstract class PreconfiguredActivity(
9090
}
9191

9292
private fun getPreferences(): Preferences =
93-
async { koin().get<GetPreferencesUseCase>().getPreferences() }.get()
93+
async { get<GetPreferencesUseCase>().getPreferences() }.get()
9494

9595
@Composable
9696
abstract fun Content(padding: PaddingValues)
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package br.com.dillmann.fireflycompanion.android.core.i18n
22

3-
import br.com.dillmann.fireflycompanion.android.core.koin.KoinManager.koin
3+
import br.com.dillmann.fireflycompanion.android.core.koin.get
44
import br.com.dillmann.fireflycompanion.database.context.ContextProvider
55
import kotlinx.coroutines.runBlocking
66

77
fun i18n(key: Int): String =
8-
runBlocking { koin().get<ContextProvider>().resolve() }.getString(key)
8+
runBlocking { get<ContextProvider>().resolve() }.getString(key)
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package br.com.dillmann.fireflycompanion.android.core.koin
2+
3+
inline fun <reified T: Any> get() =
4+
KoinManager.koin().get<T>()

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/home/accounts/HomeAccountsTab.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import br.com.dillmann.fireflycompanion.android.core.components.section.Section
2424
import br.com.dillmann.fireflycompanion.android.core.compose.persistent
2525
import br.com.dillmann.fireflycompanion.android.core.compose.volatile
2626
import br.com.dillmann.fireflycompanion.android.core.i18n.i18n
27-
import br.com.dillmann.fireflycompanion.android.core.koin.KoinManager.koin
27+
import br.com.dillmann.fireflycompanion.android.core.koin.get
2828
import br.com.dillmann.fireflycompanion.android.core.queue.ActionQueue
2929
import br.com.dillmann.fireflycompanion.android.core.refresh.OnRefreshEvent
3030
import br.com.dillmann.fireflycompanion.android.core.router.Route
@@ -40,7 +40,7 @@ fun HomeAccountsTab(
4040
modifier: Modifier = Modifier,
4141
) {
4242
val queue by persistent(ActionQueue())
43-
val listUseCase = koin().get<ListAccountsUseCase>()
43+
val listUseCase = get<ListAccountsUseCase>()
4444
var accounts by persistent(emptyList<Account>())
4545
var currentPage by persistent(0)
4646
var hasMorePages by persistent(true)

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/home/assistant/HomeAssistantTab.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,21 +29,21 @@ import br.com.dillmann.fireflycompanion.android.core.compose.persistent
2929
import br.com.dillmann.fireflycompanion.android.core.compose.volatile
3030
import br.com.dillmann.fireflycompanion.android.core.context.AppContext
3131
import br.com.dillmann.fireflycompanion.android.core.i18n.i18n
32+
import br.com.dillmann.fireflycompanion.android.core.koin.get
3233
import br.com.dillmann.fireflycompanion.android.core.queue.ActionQueue
3334
import br.com.dillmann.fireflycompanion.business.assistant.AssistantSession
3435
import br.com.dillmann.fireflycompanion.business.assistant.AssistantSession.State
3536
import br.com.dillmann.fireflycompanion.business.assistant.model.AssistantMessage
3637
import br.com.dillmann.fireflycompanion.business.assistant.usecase.StartAssistantSessionUseCase
3738
import kotlinx.coroutines.launch
38-
import org.koin.java.KoinJavaComponent.getKoin
3939
import java.time.OffsetDateTime
4040
import java.time.format.DateTimeFormatter
4141
import java.time.format.FormatStyle
4242

4343
@Composable
4444
@OptIn(ExperimentalMaterial3Api::class)
4545
fun HomeAssistantTab() {
46-
val useCase = getKoin().get<StartAssistantSessionUseCase>()
46+
val useCase = get<StartAssistantSessionUseCase>()
4747
var messages by persistent(emptyList<AssistantMessage>())
4848
val session by volatile { useCase.startSession(AppContext.currentLocale().toLanguageTag()) }
4949

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/home/main/HomeAccountsOverview.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import br.com.dillmann.fireflycompanion.android.core.components.section.SectionC
2222
import br.com.dillmann.fireflycompanion.android.core.compose.persistent
2323
import br.com.dillmann.fireflycompanion.android.core.compose.volatile
2424
import br.com.dillmann.fireflycompanion.android.core.i18n.i18n
25+
import br.com.dillmann.fireflycompanion.android.core.koin.get
2526
import br.com.dillmann.fireflycompanion.android.core.queue.ActionQueue
2627
import br.com.dillmann.fireflycompanion.android.core.refresh.OnRefreshEvent
2728
import br.com.dillmann.fireflycompanion.android.core.theme.AppColors
@@ -32,7 +33,6 @@ import br.com.dillmann.fireflycompanion.business.account.usecase.GetAccountOverv
3233
import br.com.dillmann.fireflycompanion.business.preferences.usecase.GetPreferencesUseCase
3334
import ir.ehsannarmani.compose_charts.LineChart
3435
import ir.ehsannarmani.compose_charts.models.*
35-
import org.koin.mp.KoinPlatform.getKoin
3636

3737
@Composable
3838
fun HomeAccountsOverview() {
@@ -131,8 +131,8 @@ private fun Graph(overview: List<AccountOverview>) {
131131
}
132132

133133
private suspend fun fetchOverview(): List<AccountOverview> {
134-
val overviewUseCase = getKoin().get<GetAccountOverviewUseCase>()
135-
val preferencesUseCase = getKoin().get<GetPreferencesUseCase>()
134+
val overviewUseCase = get<GetAccountOverviewUseCase>()
135+
val preferencesUseCase = get<GetPreferencesUseCase>()
136136
val (startDate, endDate) = preferencesUseCase.getPreferences().homePeriod.toDateRange()
137137
return overviewUseCase.getOverview(startDate, endDate)
138138
}

android/src/main/kotlin/br/com/dillmann/fireflycompanion/android/home/main/HomeCreditCards.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import br.com.dillmann.fireflycompanion.android.core.components.money.MoneyText
2525
import br.com.dillmann.fireflycompanion.android.core.components.section.SectionCard
2626
import br.com.dillmann.fireflycompanion.android.core.compose.persistent
2727
import br.com.dillmann.fireflycompanion.android.core.i18n.i18n
28+
import br.com.dillmann.fireflycompanion.android.core.koin.get
2829
import br.com.dillmann.fireflycompanion.android.core.queue.ActionQueue
2930
import br.com.dillmann.fireflycompanion.android.core.refresh.OnRefreshEvent
3031
import br.com.dillmann.fireflycompanion.android.core.router.Route
@@ -34,7 +35,6 @@ import br.com.dillmann.fireflycompanion.business.account.Account
3435
import br.com.dillmann.fireflycompanion.business.account.usecase.ListAccountsUseCase
3536
import br.com.dillmann.fireflycompanion.business.transaction.Transaction
3637
import br.com.dillmann.fireflycompanion.core.pagination.fetchAllPages
37-
import org.koin.java.KoinJavaComponent.getKoin
3838
import java.math.BigDecimal
3939
import java.time.OffsetDateTime
4040

@@ -172,7 +172,7 @@ private fun openAccountForm(account: Account) {
172172
}
173173

174174
private suspend fun fetchCreditCards(): List<Account> {
175-
val useCase = getKoin().get<ListAccountsUseCase>()
175+
val useCase = get<ListAccountsUseCase>()
176176
return fetchAllPages { useCase.listAccounts(it) }
177177
.filter { it.role == Account.Role.CREDIT_CARD }
178178
}

0 commit comments

Comments
 (0)