Fix Javadoc errors blocking release build

Author: zspitzer

source/java/src/org/lucee/extension/orm/hibernate/HibernateCaster.java

@@ -429,10 +429,10 @@ public static Object toHibernateValue(PageContext pc, Object value, String type)
 
 	/**
 	 * translate CFMl specific types to Hibernate/SQL specific types
-	 * 
-	 * @param engine
+	 *
 	 * @param ci
 	 * @param value
+	 * @param isArray
 	 * @return
 	 * @throws PageException
 	 */
@@ -442,10 +442,10 @@ public static Object toSQL(ColumnInfo ci, Object value, RefBoolean isArray) thro
 
 	/**
 	 * translate CFMl specific types to Hibernate/SQL specific types
-	 * 
-	 * @param engine
+	 *
 	 * @param type
 	 * @param value
+	 * @param isArray
 	 * @return
 	 * @throws PageException
 	 */
@@ -457,10 +457,10 @@ public static Object toSQL(Type type, Object value, RefBoolean isArray) throws P
 
 	/**
 	 * translate CFMl specific type to SQL specific types
-	 * 
-	 * @param engine
+	 *
 	 * @param sqlType
 	 * @param value
+	 * @param isArray
 	 * @return
 	 * @throws PageException
 	 */

source/java/src/org/lucee/extension/orm/hibernate/functions/EntityNew.java

@@ -62,8 +62,8 @@ public static Object call( PageContext pc, String name, Struct properties ) thro
 
 	/**
 	 *
-	 * @TODO: Move this to a reusable EntityPopulator? Do we populate entities anywhere else?
-	 * @TODO: Either drop ignoreNotExisting argument, or implement a 'true' condition. This is always `false`, currently.
+	 * TODO: Move this to a reusable EntityPopulator? Do we populate entities anywhere else?
+	 * TODO: Either drop ignoreNotExisting argument, or implement a 'true' condition. This is always {@code false}, currently.
 	 *
 	 * @param pc                Lucee PageContext
 	 * @param c                 The new entity Component

source/java/src/org/lucee/extension/orm/hibernate/mapping/CFConstants.java

@@ -222,8 +222,8 @@ public static boolean isValidValue( String value ) {
 	}
 
 	/**
-	 * @TODO: Move this into some CFConstants class, or somewhere that both HBMCreator and HibernateCaster can reference it.
-	 * @TODO: @nextMajorRelease, Migrate to Map.of() or Map.ofEntries in Java 9+
+	 * TODO: Move this into some CFConstants class, or somewhere that both HBMCreator and HibernateCaster can reference it.
+	 * TODO: @nextMajorRelease, Migrate to Map.of() or Map.ofEntries in Java 9+
 	 */
 	public static class Relationships {
 

source/java/src/org/lucee/extension/orm/hibernate/mapping/HBMCreator.java

@@ -47,22 +47,22 @@ private HBMCreator() {}
 	/**
 	 * Hibernate DOCTYPE mapping ID
 	 *
-	 * @see https://docs.jboss.org/hibernate/orm/5.4/userguide/html_single/Hibernate_User_Guide.html#schema-generation-database-objects
+	 * @see <a href="https://docs.jboss.org/hibernate/orm/5.4/userguide/html_single/Hibernate_User_Guide.html#schema-generation-database-objects">Hibernate User Guide</a>
 	 */
 	public static final String HIBERNATE_3_PUBLIC_ID = "-//Hibernate/Hibernate Mapping DTD 3.0//EN";
 
 	/**
 	 * Hibernate doctype reference
 	 *
-	 * @see https://docs.jboss.org/hibernate/orm/5.4/userguide/html_single/Hibernate_User_Guide.html#schema-generation-database-objects
+	 * @see <a href="https://docs.jboss.org/hibernate/orm/5.4/userguide/html_single/Hibernate_User_Guide.html#schema-generation-database-objects">Hibernate User Guide</a>
 	 */
 	// public static final String HIBERNATE_3_SYSTEM_ID = "http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd";
 	public static final String HIBERNATE_3_SYSTEM_ID = "http://www.hibernate.org/dtd/hibernate-mapping-3.0.dtd";
 
 	/**
 	 * Full XML doctype for Hibernate mappings
 	 *
-	 * @see https://docs.jboss.org/hibernate/orm/5.4/userguide/html_single/Hibernate_User_Guide.html#schema-generation-database-objects
+	 * @see <a href="https://docs.jboss.org/hibernate/orm/5.4/userguide/html_single/Hibernate_User_Guide.html#schema-generation-database-objects">Hibernate User Guide</a>
 	 */
 	public static final String HIBERNATE_3_DOCTYPE_DEFINITION = "<!DOCTYPE hibernate-mapping PUBLIC \""
 			+ HIBERNATE_3_PUBLIC_ID + "\" \"" + HIBERNATE_3_SYSTEM_ID + "\">";
@@ -1962,7 +1962,7 @@ public static String loadMapping(Component cfc) throws PageException, IOExceptio
 	 *         since the epoch (00:00:00 GMT, January 1, 1970), or <code>0L</code> if the file does not exist or if an
 	 *         I/O error occurs
 	 *
-	 * @see lucee.commons.io.res.Resource#lastModified();
+	 * @see lucee.commons.io.res.Resource#lastModified()
 	 */
 	public static long getMappingLastModified(Component cfc) {
 		Resource res = getMappingResource(cfc);
@@ -1987,7 +1987,7 @@ public static Resource getMappingResource(Component cfc) {
 	}
 
 	/**
-	 * Get the opening of a Hibernate mapping XML file, including <xml> tag and DOCTYPE declaration
+	 * Get the opening of a Hibernate mapping XML file, including {@code <?xml?>} tag and DOCTYPE declaration
 	 */
 	public static String getXMLOpen() {
 		StringBuilder xml = new StringBuilder();
@@ -1998,14 +1998,14 @@ public static String getXMLOpen() {
 	}
 
 	/**
-	 * Strip the open/close tags (i.e. `<xml>`, `<!DOCTYPE>`, `<hibernate-mapping>`) from an hbm.xml file.
+	 * Strip the open/close tags (i.e. {@code <?xml?>}, {@code <!DOCTYPE>}, {@code <hibernate-mapping>}) from an hbm.xml file.
 	 * <p>
-	 * Useful for assembling multiple entities into a single `<hibernate-mapping>` element for sending to Hibernate.
+	 * Useful for assembling multiple entities into a single {@code <hibernate-mapping>} element for sending to Hibernate.
 	 *
 	 * @param xml
 	 *            XML string from which to strip open and close tags
 	 *
-	 * @return an XML string with the DOCTYPE, `<xml>` and `<hibernate-mapping>` elements removed
+	 * @return an XML string with the DOCTYPE, {@code <?xml?>} and {@code <hibernate-mapping>} elements removed
 	 */
 	public static String stripXMLOpenClose(String xml) {
 		return xml.replaceAll("<\\?xml[^>]+>", "").replaceAll("<!DOCTYPE[^>]+>", "").replaceAll("</?hibernate-mapping>",

source/java/src/org/lucee/extension/orm/hibernate/util/CommonUtil.java

@@ -496,7 +496,7 @@ public static boolean isStruct(Object obj) {
 	 * Blatantly copied from Lucee core because it's not in the Lucee loader, so we don't have access to run it without
 	 * reflection.
 	 *
-	 * @link https://github.com/lucee/Lucee/blob/6.0/core/src/main/java/lucee/runtime/op/Decision.java#L964
+	 * @see <a href="https://github.com/lucee/Lucee/blob/6.0/core/src/main/java/lucee/runtime/op/Decision.java#L964">Lucee core Decision.java</a>
 	 *
 	 * @param o
 	 *            Value to compare
@@ -1039,7 +1039,7 @@ public static Calendar toCalendar(DateTime date, TimeZone timeZone, Locale local
 	 * <p>
 	 * Blatantly copied from the Lucee core, since we don't have access to this method without reflection.
 	 *
-	 * @link https://github.com/lucee/Lucee/blob/6.0/core/src/main/java/lucee/commons/lang/StringUtil.java#L870
+	 * @see <a href="https://github.com/lucee/Lucee/blob/6.0/core/src/main/java/lucee/commons/lang/StringUtil.java#L870">Lucee core StringUtil.java</a>
 	 *
 	 * @param str
 	 *            string to check first char
@@ -1057,7 +1057,7 @@ public static boolean startsWith(String str, char prefix) {
 	 * <p>
 	 * Blatantly copied from the Lucee core, since we don't have access to this method without reflection.
 	 *
-	 * @link https://github.com/lucee/Lucee/blob/6.0/core/src/main/java/lucee/commons/lang/StringUtil.java#L870
+	 * @see <a href="https://github.com/lucee/Lucee/blob/6.0/core/src/main/java/lucee/commons/lang/StringUtil.java#L870">Lucee core StringUtil.java</a>
 	 *
 	 * @param str
 	 *            string to check first char

source/java/src/org/lucee/extension/orm/hibernate/util/ConfigurationBuilder.java

@@ -47,22 +47,8 @@ public class ConfigurationBuilder {
     private Log log;
 
     /**
-     * Build out Hibernate configuration using the application's `this.ormSettings`, datasource, and generated mappings.
-     *
-     * @param log
-     *            Lucee logger object, configured for the ORM log
-     * @param mappings
-     *            Mapping XML document as a string
-     * @param ds
-     *            Datasource to operate on
-     * @param user
-     *            Username for the configured datasource
-     * @param pass
-     *            Password for the configured datasource
-     * @param data
-     *            The extension {@link org.lucee.extension.orm.hibernate.SessionFactoryData}
-     * @param applicationName
-     *            Application name
+     * Build out Hibernate configuration using the application's {@code this.ormSettings}, datasource, and generated mappings.
+     * Use the builder setter methods to configure log, mappings, datasource, credentials, data, and application name before calling.
      *
      * @return Hibernate Configuration object
      *

source/java/src/org/lucee/extension/orm/hibernate/util/XMLUtil.java

@@ -78,7 +78,7 @@ public static Document newDocument() throws PageException {
      * @param document
      *            The root element of an XML document.
      *
-     * @return a fully-formed and formatted XML string. Does not append or prepend <xml> tags or DOCTYPE, etc.
+     * @return a fully-formed and formatted XML string. Does not append or prepend {@code <xml>} tags or DOCTYPE, etc.
      *
      * @throws PageException
      */