fix error code 4

Author: Your Name

beanborg/bb_archive.py

@@ -9,6 +9,7 @@
 import shutil
 import sys
 from datetime import datetime
+from typing import Optional
 
 import fire
 from fire.decorators import SetParseFns
@@ -37,18 +38,29 @@ class BeanborgArchiver:
         bb_archive --config_file=/path/to/config.yaml --debug=true
     """
 
-    @SetParseFns(config_file=str, debug=bool)
-    def __call__(self, config_file: str, debug: bool = False) -> int:
+    @SetParseFns(f=str, config_file=str, debug=bool)
+    def __call__(
+        self,
+        f: Optional[str] = None,
+        config_file: Optional[str] = None,
+        debug: bool = False,
+    ):
         """Archive the processed CSV file.
 
         Args:
+            f: Path to the configuration file (shorthand for --config-file)
             config_file: Path to the configuration file
             debug: Enable debug mode
 
         Returns:
             int: 0 for success, 1 for failure
         """
-        config = init_config(config_file,debug)
+        final_config_file = f or config_file
+        if not final_config_file:
+            raise ValueError(
+                "Configuration file must be specified using either -f or --config-file"
+            )
+        config = init_config(final_config_file, debug)
 
         target_csv = os.path.join(config.csv.target, config.csv.ref + ".csv")
 

beanborg/bb_import.py

@@ -4,6 +4,8 @@
 __copyright__ = "Copyright (C) 2024  Luciano Fiandesio"
 __license__ = "GNU GPLv2"
 
+from typing import Optional
+
 import fire
 from fire.decorators import SetParseFns
 
@@ -31,17 +33,29 @@ class BeanborgImporter:
         bb_import --config_file=config.yaml --fix_only=true
     """
 
-    @SetParseFns(config_file=str, debug=bool, fix_only=bool)
-    def __call__(self, config_file: str, debug: bool = False, fix_only: bool = False):
+    @SetParseFns(f=str, config_file=str, debug=bool, fix_only=bool)
+    def __call__(
+        self,
+        f: Optional[str] = None,
+        config_file: Optional[str] = None,
+        debug: bool = False,
+        fix_only: bool = False,
+    ):
         """Import transactions from CSV to beancount.
 
         Args:
+            f: Path to the configuration file (shorthand for --config-file)
             config_file: Path to the configuration file
             debug: Enable debug mode
             fix_only: Only fix uncategorized transactions
         """
+        final_config_file = f or config_file
+        if not final_config_file:
+            raise ValueError(
+                "Configuration file must be specified using either -f or --config-file"
+            )
         imp = Importer()
-        return imp.import_transactions(config_file, debug, fix_only)
+        return imp.import_transactions(final_config_file, debug, fix_only)
 
 
 def main():

beanborg/bb_mover.py

@@ -7,6 +7,7 @@
 import glob
 import os
 import shutil
+import sys
 from subprocess import CalledProcessError, check_call
 from typing import Optional
 
@@ -70,7 +71,7 @@ def _process(self, config_file: str, debug: bool = False):
         path = os.path.expanduser(config.csv.download_path)
         if not os.path.isdir(path):
             rprint(f"[red]folder: {config.csv.download_path} does not exist![/red]")
-            return 1
+            sys.exit(-1)
 
         if not os.path.isdir(config.csv.target):
             os.mkdir(config.csv.target)
@@ -83,20 +84,20 @@ def _process(self, config_file: str, debug: bool = False):
                 f"more than one file starting with {config.csv.name} "
                 f"found in {config.csv.download_path}. Cannot continue."
             )
-            return 1
+            sys.exit(-1)
 
         if file_count == 0:
             rprint(
                 f"[red]No file found in [bold]{config.csv.download_path}[/bold] "
                 f"with name starting with: [bold]{config.csv.name}[/bold][/red]"
             )
-            return 1
+            sys.exit(-1)
 
         if config.csv.post_script_path and not os.path.isfile(
             config.csv.post_script_path
         ):
             print(f"No post-move script found: {config.csv.post_script_path}")
-            return 1
+            sys.exit(-1)
 
         for f in os.listdir(path):
             if f.startswith(config.csv.name):
@@ -120,7 +121,6 @@ def _process(self, config_file: str, debug: bool = False):
                             f"[red]An error occurred executing: {config.csv.post_script_path}\n{str(e)}[/red]"
                         )
         print("Done :)")
-        return 0
 
 
 def main():

beanborg/rule_engine/rules_engine.py

@@ -126,6 +126,7 @@ class RuleEngineError(Exception):
     """Base exception for rule engine errors."""
 
     def __init__(self, message: str, context: Optional[RuleErrorContext] = None):
+        """Initialize the exception."""
         self.context = context or RuleErrorContext()
         super().__init__(message)
 
@@ -134,6 +135,7 @@ class RuleLoadError(RuleEngineError):
     """Exception raised when rule loading fails."""
 
     def __str__(self) -> str:
+        """Return a string representation of the exception."""
         context_info = []
         if self.context.rule_name:
             context_info.append(f"rule='{self.context.rule_name}'")
@@ -201,21 +203,21 @@ def _load_rules(self) -> None:
                 try:
                     if rule_name in custom_rules:
                         logger.debug("Loading custom rule: %s", rule_name)
-                        self.rules[rule_name] = RuleDef(custom_rules[rule_name], rule_props)
+                        self.rules[rule_name] = RuleDef(
+                            custom_rules[rule_name], rule_props
+                        )
                     elif rule_name in self.BUILT_IN_RULES:
                         # Load from built-in rules
                         logger.debug("Loading built-in rule: %s", rule_name)
                         unique_name = f"{rule_name}|{uuid.uuid4().hex.upper()[:6]}"
                         self.rules[unique_name] = RuleDef(
-                        self.BUILT_IN_RULES[rule_name], rule_props
-                    )
+                            self.BUILT_IN_RULES[rule_name], rule_props
+                        )
                     else:
                         logger.error("Unknown rule: %s", rule_name)
                         raise RuleLoadError(f"Unknown rule type: {rule_name}")
                 except Exception as e:
-                    raise RuleLoadError(
-                        f"Failed to load rule '{rule_name}'"
-                    ) from e
+                    raise RuleLoadError(f"Failed to load rule '{rule_name}'") from e
         except Exception as e:
             if not isinstance(e, RuleLoadError):
                 raise RuleLoadError("Failed to load rules") from e