Remove error responses for single doc ingestion APIS (Index, Update, Get, Delete Doc) (opensearch-project#260)

Author: karenyrx

CHANGELOG.md

@@ -10,6 +10,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Revert bulk response back to without error response ([#256](https://github.com/opensearch-project/opensearch-protobufs/pull/256))
 - Change `indices_boost` to single map and rename request_body to bulk_request_body ([#257](https://github.com/opensearch-project/opensearch-protobufs/pull/257))
 ### Removed
+- Remove error responses for single doc ingestion APIS (Index, Update, Get, Delete Doc) ([#258](https://github.com/opensearch-project/opensearch-protobufs/pull/258))
 
 ### Fixed
 

protos/schemas/document.proto

@@ -317,23 +317,6 @@ message IndexDocumentRequest {
   optional SourceType source_type = 16;
 }
 
-// The response from index document request
-message IndexDocumentResponse {
-  oneof response {
-    // Index document success response
-    IndexDocumentResponseBody index_document_response_body = 1;
-    // Index document failure response
-    IndexDocumentErrorResponse index_document_error_response = 2;
-  }
-}
-
-// The error response from index document request
-message IndexDocumentErrorResponse {
-  // [optional]
-  optional Error error = 1;
-  // [optional] HTTP response status code
-  optional int32 status = 2;
-}
 
 enum Result {
   RESULT_UNSPECIFIED = 0;
@@ -344,7 +327,8 @@ enum Result {
   RESULT_UPDATED = 5;
 }
 
-message IndexDocumentResponseBody {
+// The response from index document request
+message IndexDocumentResponse {
   // [optional] The document type.
   optional string x_type = 1;
   // [optional] The document's ID.
@@ -359,7 +343,7 @@ message IndexDocumentResponseBody {
   // [optional] The sequence number assigned when the document was indexed.
   optional int64 x_seq_no = 6;
   // [optional] Detailed information about the cluster's shards.
-  ShardStatistics x_shards = 7;
+  optional ShardStatistics x_shards = 7;
   // [optional] The document's version.
   optional int64 x_version = 8;
   // [optional] if `true`, it requires immediate visibility of the document
@@ -393,7 +377,8 @@ message DeleteDocumentRequest {
   optional WaitForActiveShards wait_for_active_shards = 10;
 }
 
-message DeleteDocumentResponseBody {
+// The response from delete index document with Id request
+message DeleteDocumentResponse {
   // [optional] The document type.
   optional string x_type = 1;
   // [optional] The document's ID.
@@ -415,21 +400,6 @@ message DeleteDocumentResponseBody {
 
 }
 
-// The response from delete index document with Id request
-message DeleteDocumentResponse {
-  oneof response {
-    DeleteDocumentResponseBody delete_document_response_body = 1;
-    DeleteDocumentErrorResponse delete_document_error_response = 2;
-  }
-}
-// The error response from delete index document with Id request
-message DeleteDocumentErrorResponse {
-  // [optional]
-  optional Error error = 1;
-  // [optional] HTTP response status code
-  optional int32 status = 2;
-}
-
 // Update index document with Id request
 message UpdateDocumentRequest {
   // [optional] Unique identifier for the document.
@@ -507,20 +477,6 @@ message UpdateDocumentRequestBody {
 
 // The response from update index document with Id request
 message UpdateDocumentResponse {
-  oneof response {
-    UpdateDocumentResponseBody update_document_response_body = 1;
-    UpdateDocumentErrorResponse update_document_error_response = 2;
-  }
-}
-// The error response from update index document with Id request
-message UpdateDocumentErrorResponse {
-  // [optional]
-  optional Error error = 1;
-  // [optional]  HTTP response status code
-  optional int32 status = 2;
-}
-
-message UpdateDocumentResponseBody {
   // [optional] The document type.
   optional string x_type = 1;
   // [optional] The document's ID.
@@ -577,13 +533,14 @@ message GetDocumentRequest {
   optional SourceType source_type = 13;
 }
 
-message GetDocumentResponseBody {
+// The response from get document request with document ID specified request
+message GetDocumentResponse {
   // [optional] The document type.
   optional string x_type = 1;
   // [optional] The name of the index.
   optional string x_index = 2;
   // [optional] Contains the document's data that's stored in the index. Only returned if both stored_fields and found are true.
-  ObjectMap fields = 3;
+  optional ObjectMap fields = 3;
   // [optional] Whether the document exists.
   optional bool found = 4;
   // [optional] The document's ID.
@@ -607,18 +564,3 @@ message GetDocumentResponseBody {
   // [optional] The document's version number. Updated whenever the document changes.
   optional int64 x_version = 10;
 }
-
-// The response from get document request with document ID specified request
-message GetDocumentResponse {
-  oneof response {
-    GetDocumentResponseBody get_document_response_body = 1;
-    GetDocumentErrorResponse get_document_error_response = 2;
-  }
-}
-// The error response from get document request with document ID specified request
-message GetDocumentErrorResponse {
-  // [optional]
-  optional Error error = 1;
-  // [optional] HTTP response status code
-  optional int32 status = 2;
-}