Skip to content

Commit d6214a3

Browse files
authored
Revert "Revert bulk response back to without error response. (opensearch-project#232)" (opensearch-project#238)
This reverts commit e180e7e. Signed-off-by: lucy66hw <fridalu66@gmail.com>
1 parent 8a2168c commit d6214a3

2 files changed

Lines changed: 19 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
66
### Added
77

88
### Changed
9-
9+
- Revert "Revert bulk response back to without error response. ([#238](https://github.com/opensearch-project/opensearch-protobufs/pull/238))
1010
### Removed
1111

1212
### Fixed

protos/schemas/document.proto

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,25 @@ message DeleteOperation {
183183
}
184184

185185
// todo: Proposal Spec this name
186+
// Bulk response contains the individual results of each operation in the request, returned in the order submitted. The success or failure of an individual operation does not affect other operations in the request.
186187
message BulkResponse {
188+
oneof response {
189+
// The bulk success response
190+
BulkResponseBody bulk_response_body = 1;
191+
// The bulk error response
192+
BulkErrorResponse bulk_error_response = 2;
193+
}
194+
}
195+
196+
message BulkErrorResponse {
197+
// [optional] The bulk error
198+
optional Error error = 1;
199+
// [optional] HTTP response status code
200+
optional int32 status = 2;
201+
}
202+
203+
message BulkResponseBody {
204+
187205
// [required] If true, one or more of the operations in the bulk request did not complete successfully.
188206
bool errors = 1;
189207
// [required] Contains the result of each operation in the bulk request, in the order they were submitted.

0 commit comments

Comments
 (0)