-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Description
Ludwig Hyperopt runs into an error , when custom callbacks are included , otherwise it runs fine.
Steps to reproduce the behavior:
-
Attached is the python code which uses ludwig hyperopt , a dataset file and a callback class , output log file.
-
Run the file model_hyperopt_example.py to see the error
-
Ludwig version used was 0.10.3 , this issue was also seen on 0.10.4
Following exception occurs
File "/data/sumanthn/ludwig_venv/lib64/python3.8/site-packages/ludwig/trainers/trainer.py", line 1278, in _train_loop
self.callback(lambda c: c.on_batch_end(self, progress_tracker, save_path, sync_step=should_step))
File "/data/sumanthn/ludwig_venv/lib64/python3.8/site-packages/ludwig/trainers/trainer.py", line 1708, in callback
fn(callback)
File "/data/sumanthn/ludwig_venv/lib64/python3.8/site-packages/ludwig/trainers/trainer.py", line 1278, in
self.callback(lambda c: c.on_batch_end(self, progress_tracker, save_path, sync_step=should_step))
TypeError: on_batch_end() got an unexpected keyword argument 'sync_step
When i edited the trainer.py , line 1278 and removed sync_step attribute , it worked fine, Hyperopt completed successfully.
Environment
- OS: Red hat Linux
- Python version : 3.8.x
- Ludwig version: 0.10.3 or 0.10.4
hyperopt_callback.txt
model_hyperopt_example.txt
output.txt
winequalityN.csv