[fix] Tokenize open shortcuts with shlex and return typed exit error (#169) (#188)

- Replace strings.Fields with shlex.Split in resolveShortcut so quoted
  args like 'sh -c "echo hi"' tokenize correctly instead of splitting
  on whitespace only
- Replace os.Exit in RunE with return &output.SilentError so cobra
  lifecycle (deferred cleanup, post-hooks, test harness) is not bypassed
- Add unit tests for quoted-arg and invalid-quoting cases
- Add e2e test TestOpenQuotedShortcut verifying end-to-end behaviour

Author: lugassawan

cmd/open.go

@@ -8,7 +8,9 @@ import (
 	"sort"
 	"strings"
 
+	"github.com/google/shlex"
 	"github.com/lugassawan/rimba/internal/config"
+	"github.com/lugassawan/rimba/internal/output"
 	"github.com/spf13/cobra"
 )
 
@@ -74,7 +76,7 @@ Shortcuts are configured in .rimba/settings.toml:
 		if err := sub.Run(); err != nil {
 			var exitErr *exec.ExitError
 			if errors.As(err, &exitErr) {
-				os.Exit(exitErr.ExitCode())
+				return &output.SilentError{ExitCode: exitErr.ExitCode()}
 			}
 			return fmt.Errorf("failed to run %q: %w", cmdArgs[0], err)
 		}
@@ -138,7 +140,10 @@ func resolveShortcut(cmd *cobra.Command, name string) ([]string, error) {
 		return nil, fmt.Errorf("shortcut %q not found in [open] config; available: %s", name, availableShortcuts(cfg.Open))
 	}
 
-	parts := strings.Fields(value)
+	parts, err := shlex.Split(value)
+	if err != nil {
+		return nil, fmt.Errorf("invalid shortcut %q in [open] config: %w\nTo fix: check quoting in .rimba/settings.toml", name, err)
+	}
 	if len(parts) == 0 {
 		return nil, fmt.Errorf("shortcut %q has empty value in [open] config", name)
 	}

cmd/open_test.go

@@ -88,6 +88,14 @@ func TestResolveOpenCommand(t *testing.T) {
 	}
 	cfgNoOpen := &config.Config{WorktreeDir: "../wt", DefaultSource: "main"}
 	cfgEmpty := &config.Config{WorktreeDir: "../wt", DefaultSource: "main", Open: map[string]string{"empty": ""}}
+	cfgQuoted := &config.Config{
+		WorktreeDir:   "../wt",
+		DefaultSource: "main",
+		Open: map[string]string{
+			"wrap": `sh -c "echo hi"`,
+			"bad":  `echo "unterminated`,
+		},
+	}
 
 	tests := []struct {
 		name       string
@@ -134,6 +142,14 @@ func TestResolveOpenCommand(t *testing.T) {
 			name:       "inline args passed through",
 			inlineArgs: []string{"pwd"}, wantArgs: []string{"pwd"},
 		},
+		{
+			name: "quoted shortcut args tokenized correctly", cfg: cfgQuoted,
+			withVal: "wrap", wantArgs: []string{"sh", "-c", "echo hi"},
+		},
+		{
+			name: "invalid quoting in shortcut returns error", cfg: cfgQuoted,
+			withVal: "bad", wantErr: "invalid shortcut",
+		},
 	}
 
 	for _, tt := range tests {

go.mod

@@ -3,6 +3,7 @@ module github.com/lugassawan/rimba
 go 1.25.7
 
 require (
+	github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
 	github.com/mark3labs/mcp-go v0.47.1
 	github.com/pelletier/go-toml/v2 v2.3.0
 	github.com/spf13/cobra v1.10.2

go.sum

@@ -7,6 +7,8 @@ github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
 github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
 github.com/google/jsonschema-go v0.4.2 h1:tmrUohrwoLZZS/P3x7ex0WAVknEkBZM46iALbcqoRA8=
 github.com/google/jsonschema-go v0.4.2/go.mod h1:r5quNTdLOYEz95Ru18zA0ydNbBuYoo9tgaYcxEYhJVE=
+github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 h1:El6M4kTTCOh6aBiKaUGG7oYTSPP8MxqL4YI3kZKwcP4=
+github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
 github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=

tests/e2e/open_test.go

@@ -193,3 +193,16 @@ func TestOpenShortcutExitCode(t *testing.T) {
 		t.Error("expected non-zero exit code from shortcut running 'false'")
 	}
 }
+
+func TestOpenQuotedShortcut(t *testing.T) {
+	if testing.Short() {
+		t.Skip(skipE2E)
+	}
+
+	repo := setupInitializedRepo(t)
+	setupOpenShortcuts(t, repo, map[string]string{"wrap": `sh -c "echo hello world"`})
+	rimbaSuccess(t, repo, "add", "open-quoted")
+
+	r := rimbaSuccess(t, repo, "open", "open-quoted", "-w", "wrap")
+	assertContains(t, r.Stdout, "hello world")
+}