feat: live config reload

this is a workaround for https://bugs.kde.org/show_bug.cgi?id=505251

Author: luisbocanegra

.clang-format

@@ -1,225 +1,95 @@
 ---
-Language: Cpp
-# BasedOnStyle:  LLVM
-AccessModifierOffset: -2
-AlignAfterOpenBracket: Align
-AlignArrayOfStructures: None
-AlignConsecutiveAssignments:
-    Enabled: false
-    AcrossEmptyLines: false
-    AcrossComments: false
-    AlignCompound: false
-    PadOperators: true
-AlignConsecutiveBitFields:
-    Enabled: false
-    AcrossEmptyLines: false
-    AcrossComments: false
-    AlignCompound: false
-    PadOperators: false
-AlignConsecutiveDeclarations:
-    Enabled: false
-    AcrossEmptyLines: false
-    AcrossComments: false
-    AlignCompound: false
-    PadOperators: false
-AlignConsecutiveMacros:
-    Enabled: false
-    AcrossEmptyLines: false
-    AcrossComments: false
-    AlignCompound: false
-    PadOperators: false
-AlignEscapedNewlines: Right
-AlignOperands: Align
-AlignTrailingComments:
-    Kind: Always
-    OverEmptyLines: 0
-AllowAllArgumentsOnNextLine: true
-AllowAllParametersOfDeclarationOnNextLine: true
-AllowShortBlocksOnASingleLine: Never
-AllowShortCaseLabelsOnASingleLine: false
-AllowShortEnumsOnASingleLine: true
-AllowShortFunctionsOnASingleLine: All
-AllowShortIfStatementsOnASingleLine: Never
-AllowShortLambdasOnASingleLine: All
-AllowShortLoopsOnASingleLine: false
-AlwaysBreakAfterDefinitionReturnType: None
-AlwaysBreakAfterReturnType: None
-AlwaysBreakBeforeMultilineStrings: false
-AlwaysBreakTemplateDeclarations: MultiLine
-AttributeMacros:
-    - __capability
-BinPackArguments: true
-BinPackParameters: true
-BitFieldColonSpacing: Both
-BraceWrapping:
-    AfterCaseLabel: false
-    AfterClass: false
-    AfterControlStatement: Never
-    AfterEnum: false
-    AfterExternBlock: false
-    AfterFunction: false
-    AfterNamespace: false
-    AfterObjCDeclaration: false
-    AfterStruct: false
-    AfterUnion: false
-    BeforeCatch: false
-    BeforeElse: false
-    BeforeLambdaBody: false
-    BeforeWhile: false
-    IndentBraces: false
-    SplitEmptyFunction: true
-    SplitEmptyRecord: true
-    SplitEmptyNamespace: true
-BreakAfterAttributes: Never
-BreakAfterJavaFieldAnnotations: false
-BreakArrays: true
-BreakBeforeBinaryOperators: None
-BreakBeforeConceptDeclarations: Always
-BreakBeforeBraces: Attach
-BreakBeforeInlineASMColon: OnlyMultiline
-BreakBeforeTernaryOperators: true
-BreakConstructorInitializers: BeforeColon
-BreakInheritanceList: BeforeColon
-BreakStringLiterals: true
-ColumnLimit: 120
-CommentPragmas: "^ IWYU pragma:"
-CompactNamespaces: false
-ConstructorInitializerIndentWidth: 4
-ContinuationIndentWidth: 4
-Cpp11BracedListStyle: true
-DerivePointerAlignment: false
+# SPDX-FileCopyrightText: 2019 Christoph Cullmann <cullmann@kde.org>
+# SPDX-FileCopyrightText: 2019 Gernot Gebhard <gebhard@absint.com>
+#
+# SPDX-License-Identifier: MIT
+
+# This file got automatically created by ECM, do not edit
+# See https://clang.llvm.org/docs/ClangFormatStyleOptions.html for the config options
+# and https://community.kde.org/Policies/Frameworks_Coding_Style#Clang-format_automatic_code_formatting
+# for clang-format tips & tricks
+---
+Language: JavaScript
+DisableFormat: true
+---
+Language: Json
 DisableFormat: false
-EmptyLineAfterAccessModifier: Never
-EmptyLineBeforeAccessModifier: LogicalBlock
-ExperimentalAutoDetectBinPacking: false
-FixNamespaceComments: true
-ForEachMacros:
-    - foreach
-    - Q_FOREACH
-    - BOOST_FOREACH
-IfMacros:
-    - KJ_IF_MAYBE
-IncludeBlocks: Preserve
-IncludeCategories:
-    - Regex: '^"(llvm|llvm-c|clang|clang-c)/'
-      Priority: 2
-      SortPriority: 0
-      CaseSensitive: false
-    - Regex: '^(<|"(gtest|gmock|isl|json)/)'
-      Priority: 3
-      SortPriority: 0
-      CaseSensitive: false
-    - Regex: ".*"
-      Priority: 1
-      SortPriority: 0
-      CaseSensitive: false
-IncludeIsMainRegex: "(Test)?$"
-IncludeIsMainSourceRegex: ""
-IndentAccessModifiers: false
-IndentCaseBlocks: false
-IndentCaseLabels: false
-IndentExternBlock: AfterExternBlock
-IndentGotoLabels: true
-IndentPPDirectives: None
-IndentRequiresClause: true
 IndentWidth: 4
-IndentWrappedFunctionNames: false
-InsertBraces: false
-InsertNewlineAtEOF: false
-InsertTrailingCommas: None
-IntegerLiteralSeparator:
-    Binary: 0
-    BinaryMinDigits: 0
-    Decimal: 0
-    DecimalMinDigits: 0
-    Hex: 0
-    HexMinDigits: 0
-JavaScriptQuotes: Leave
-JavaScriptWrapImports: true
-KeepEmptyLinesAtTheStartOfBlocks: true
-LambdaBodyIndentation: Signature
-LineEnding: DeriveLF
-MacroBlockBegin: ""
-MacroBlockEnd: ""
-MaxEmptyLinesToKeep: 1
-NamespaceIndentation: None
-ObjCBinPackProtocolList: Auto
-ObjCBlockIndentWidth: 2
-ObjCBreakBeforeNestedBlockParam: true
-ObjCSpaceAfterProperty: false
-ObjCSpaceBeforeProtocolList: true
-PackConstructorInitializers: BinPack
-PenaltyBreakAssignment: 2
-PenaltyBreakBeforeFirstCallParameter: 19
-PenaltyBreakComment: 300
-PenaltyBreakFirstLessLess: 120
-PenaltyBreakOpenParenthesis: 0
-PenaltyBreakString: 1000
-PenaltyBreakTemplateDeclaration: 10
-PenaltyExcessCharacter: 1000000
-PenaltyIndentedWhitespace: 0
-PenaltyReturnTypeOnItsOwnLine: 60
+---
+
+# Style for C++
+Language: Cpp
+
+# base is WebKit coding style: https://webkit.org/code-style-guidelines/
+# below are only things set that diverge from this style!
+BasedOnStyle: WebKit
+
+# enforce C++11 (e.g. for std::vector<std::vector<lala>>
+Standard: Cpp11
+
+# 4 spaces indent
+TabWidth: 4
+
+# 2 * 80 wide lines
+ColumnLimit: 160
+
+# sort includes inside line separated groups
+SortIncludes: true
+
+# break before braces on function, namespace and class definitions.
+BreakBeforeBraces: Linux
+
+# CrlInstruction *a;
 PointerAlignment: Right
-PPIndentWidth: -1
-QualifierAlignment: Leave
-ReferenceAlignment: Pointer
-ReflowComments: true
-RemoveBracesLLVM: false
-RemoveSemicolon: false
-RequiresClausePosition: OwnLine
-RequiresExpressionIndentation: OuterScope
-SeparateDefinitionBlocks: Leave
-ShortNamespaceLines: 1
-SortIncludes: CaseSensitive
-SortJavaStaticImport: Before
-SortUsingDeclarations: LexicographicNumeric
-SpaceAfterCStyleCast: false
-SpaceAfterLogicalNot: false
-SpaceAfterTemplateKeyword: true
-SpaceAroundPointerQualifiers: Default
-SpaceBeforeAssignmentOperators: true
-SpaceBeforeCaseColon: false
+
+# horizontally aligns arguments after an open bracket.
+AlignAfterOpenBracket: Align
+
+# don't move all parameters to new line
+AllowAllParametersOfDeclarationOnNextLine: false
+
+# no single line functions
+AllowShortFunctionsOnASingleLine: None
+
+# no single line enums
+AllowShortEnumsOnASingleLine: false
+
+# always break before you encounter multi line strings
+AlwaysBreakBeforeMultilineStrings: true
+
+# don't move arguments to own lines if they are not all on the same
+BinPackArguments: false
+
+# don't move parameters to own lines if they are not all on the same
+BinPackParameters: false
+
+# In case we have an if statement with multiple lines the operator should be at the beginning of the line
+# but we do not want to break assignments
+BreakBeforeBinaryOperators: NonAssignment
+
+# format C++11 braced lists like function calls
+Cpp11BracedListStyle: true
+
+# do not put a space before C++11 braced lists
 SpaceBeforeCpp11BracedList: false
-SpaceBeforeCtorInitializerColon: true
-SpaceBeforeInheritanceColon: true
-SpaceBeforeParens: ControlStatements
-SpaceBeforeParensOptions:
-    AfterControlStatements: true
-    AfterForeachMacros: true
-    AfterFunctionDefinitionName: false
-    AfterFunctionDeclarationName: false
-    AfterIfMacros: true
-    AfterOverloadedOperator: false
-    AfterRequiresInClause: false
-    AfterRequiresInExpression: false
-    BeforeNonEmptyParentheses: false
-SpaceBeforeRangeBasedForLoopColon: true
-SpaceBeforeSquareBrackets: false
-SpaceInEmptyBlock: false
-SpaceInEmptyParentheses: false
-SpacesBeforeTrailingComments: 1
-SpacesInAngles: Never
-SpacesInConditionalStatement: false
-SpacesInContainerLiterals: true
-SpacesInCStyleCastParentheses: false
-SpacesInLineCommentPrefix:
-    Minimum: 1
-    Maximum: -1
-SpacesInParentheses: false
-SpacesInSquareBrackets: false
-Standard: Latest
-StatementAttributeLikeMacros:
-    - Q_EMIT
-StatementMacros:
-    - Q_UNUSED
-    - QT_REQUIRE_VERSION
-TabWidth: 8
-UseTab: Never
-WhitespaceSensitiveMacros:
-    - BOOST_PP_STRINGIZE
-    - CF_SWIFT_NAME
-    - NS_SWIFT_NAME
-    - PP_STRINGIZE
-    - STRINGIZE
----
 
+# remove empty lines
+KeepEmptyLinesAtTheStartOfBlocks: false
+
+# no namespace indentation to keep indent level low
+NamespaceIndentation: None
+
+# we use template< without space.
+SpaceAfterTemplateKeyword: false
+
+# Always break after template declaration
+AlwaysBreakTemplateDeclarations: true
+
+# macros for which the opening brace stays attached.
+ForEachMacros: [ foreach, Q_FOREACH, BOOST_FOREACH, forever, Q_FOREVER, QBENCHMARK, QBENCHMARK_ONCE , wl_resource_for_each, wl_resource_for_each_safe ]
+
+# keep lambda formatting multi-line if not empty
+AllowShortLambdasOnASingleLine: Empty
+
+# We do not want clang-format to put all arguments on a new line
+AllowAllArgumentsOnNextLine: false

.clangd

@@ -0,0 +1,3 @@
+CompileFlags:
+  Remove:
+    - -mno-direct-extern-access

install.sh

@@ -1,4 +1,5 @@
 #!/bin/sh
+set -e
 
 if [ -d "build" ]; then
     rm -rf build

package/contents/code/utils.js

@@ -78,7 +78,7 @@ function addTrayIcon(window) {
         "toolTipText": formattedWindowInfo(window),
         "launcherUrl": launcherUrl,
         "xdgName": window.desktopFileName,
-        "countUseDot": countUseDot
+        "countUseDot": Qt.binding(function () { return countUseDot; })
     });
     trayItem.requestShowHide.connect(toggleShowHide);
     trayItem.requestClose.connect(closeWindow);

package/contents/ui/main.qml

@@ -1,17 +1,31 @@
 import QtQuick
 import org.kde.kwin
 import com.github.luisbocanegra.trayicon 1.0
+import com.github.luisbocanegra.kwinrcwatcher 1.0
 import "../code/utils.js" as Utils
 
 Item {
     id: root
-    property bool debugEnabled: KWin.readConfig("debugEnabled", false)
-    property var hideByDefaultClass: Utils.commaSeparate(KWin.readConfig("hideByDefaultClass", ""))
-    property bool countUseDot: KWin.readConfig("countUseDot", false)
-    property bool hideOnMinimize: KWin.readConfig("hideOnMinimize", false)
+    property bool debugEnabled
+    property var hideByDefaultClass
+    property bool countUseDot
+    property bool hideOnMinimize
     property var trayIcons: new Object()
     readonly property Component trayIconComponent: TrayIcon {}
 
+    function reloadConfig() {
+        console.log("KWin Minimize2Tray Reloading configuration");
+        debugEnabled = KWin.readConfig("debugEnabled", false);
+        hideByDefaultClass = Utils.commaSeparate(KWin.readConfig("hideByDefaultClass", ""));
+        countUseDot = KWin.readConfig("countUseDot", false);
+        hideOnMinimize = KWin.readConfig("hideOnMinimize", false);
+        console.log(JSON.stringify(hideByDefaultClass));
+    }
+
+    KwinrcWatcher {
+        onConfigChanged: root.reloadConfig()
+    }
+
     ShortcutHandler {
         name: "Minimize to tray"
         text: "Minimize window to tray (sets skip Taskbar, Switcher & Pager)"
@@ -29,6 +43,7 @@ Item {
     }
 
     Component.onCompleted: {
+        reloadConfig();
         Workspace.windowAdded.connect(window => Utils.setup(window));
         Workspace.windowAdded.connect(window => {
             Utils.setupAutoHide(window);

plugin/CMakeLists.txt

@@ -1,16 +1,2 @@
-set(PLUGIN_NAME "trayiconplugin")
-set(LIB_NAME "trayicon")
-
-add_library(${PLUGIN_NAME} SHARED ${PLUGIN_NAME}.cpp ${LIB_NAME}.cpp)
-find_package(Qt6 ${QT_MIN_VERSION} REQUIRED COMPONENTS DBus Qml)
-find_package(KF6 ${KF6_MIN_VERSION} REQUIRED COMPONENTS StatusNotifierItem Service)
-
-target_link_libraries(${PLUGIN_NAME}
-    Qt6::Qml
-    Qt6::DBus
-    KF6::StatusNotifierItem
-    KF6::Service
-)
-
-install(TARGETS ${PLUGIN_NAME} DESTINATION ${KDE_INSTALL_QMLDIR}/com/github/luisbocanegra/${LIB_NAME})
-install(FILES qmldir DESTINATION ${KDE_INSTALL_QMLDIR}/com/github/luisbocanegra/${LIB_NAME})
+add_subdirectory(kwinrcwatcher)
+add_subdirectory(trayicon)