fix!: require allowing floating applets changes 6.4.0 and later

Since version 6.4.0, Plasma now has a built-in Floating panel and applets option, we are overriding it since older versions blocking the user from changing it manually.

Now the user has to explicitly allow changing it so we don't alter it by default

refs: #293

BREAKING CHANGE: If you are forcing floating dialogs (applets) you will need to update your settings/presets to allow floating applets changes in plasma 6.4.0 and later **Appearance** > **Floating applets** > enable (check) allow changes

Author: luisbocanegra

package/contents/ui/code/globals.js

@@ -304,6 +304,7 @@ const defaultConfig = {
       shadow: true,
     },
     floatingDialogs: false,
+    floatingDialogsAllowOverride: false,
   },
   stockPanelSettings: baseStockPanelSettings,
   configurationOverrides: {

package/contents/ui/components/FormWidgetSettings.qml

@@ -5,6 +5,8 @@ import org.kde.kirigami as Kirigami
 import org.kde.plasma.plasmoid
 import "../code/enum.js" as Enum
 import "../code/utils.js" as Utils
+import "../code/version.js" as VersionUtil
+import ".."
 
 ColumnLayout {
     id: root
@@ -73,6 +75,23 @@ ColumnLayout {
         }
     }
 
+    property var plasmaVersion: new VersionUtil.Version("999.999.999") // to assume latest
+    RunCommand {
+        id: runCommand
+        onExited: (cmd, exitCode, exitStatus, stdout, stderr) => {
+            if (exitCode !== 0) {
+                console.error(cmd, exitCode, exitStatus, stdout, stderr);
+                return;
+            }
+            if (stdout) {
+                const parts = stdout.split(" ");
+                if (parts.length < 2)
+                    return;
+                root.plasmaVersion = new VersionUtil.Version(parts[1]);
+            }
+        }
+    }
+
     signal updateConfigString(string configString, var config)
     signal tabChanged(int currentTab)
 
@@ -92,6 +111,7 @@ ColumnLayout {
     }
     Component.onCompleted: {
         Utils.delay(50, () => ready = true, root);
+        runCommand.run('plasmashell --version');
     }
 
     Kirigami.FormLayout {
@@ -217,14 +237,33 @@ ColumnLayout {
             }
         }
 
+        RowLayout {
+            Kirigami.FormData.label: i18n("Floating applets:")
+            CheckBox {
+                id: floatingDialogsEnabledCheckbox
+                visible: elementName === "panel" && root.elementState === Enum.WidgetStates.Normal
+                text: i18n("Allow changes (Plasma 6.4.0 and later)")
+                checked: config.nativePanel.floatingDialogsAllowOverride
+                onCheckedChanged: {
+                    config.nativePanel.floatingDialogsAllowOverride = checked;
+                    updateConfig();
+                }
+            }
+            Kirigami.ContextualHelpButton {
+                toolTipText: i18n("Since version 6.4.0, Plasma now has a built-in <b>Floating panel and applets</b> option, enabling this overrides that option.\n⚠️Changing <b>Floating</b> from the panel configuration will not work with this is enabled!")
+            }
+            visible: root.plasmaVersion.isGreaterThan("6.3.5")
+        }
+
         CheckBox {
             visible: elementName === "panel" && root.elementState === Enum.WidgetStates.Normal
-            text: i18n("Force floating dialogs")
+            text: i18n("Force floating applets")
             checked: config.nativePanel.floatingDialogs
             onCheckedChanged: {
                 config.nativePanel.floatingDialogs = checked;
                 updateConfig();
             }
+            enabled: floatingDialogsEnabledCheckbox.checked || root.plasmaVersion.isLowerThan("6.4.0")
         }
 
         CheckBox {

package/contents/ui/main.qml

@@ -54,6 +54,7 @@ PlasmoidItem {
     property bool hideWidget: plasmoid.configuration.hideWidget
     property bool fixedSidePaddingEnabled: isEnabled && panelBgItem.cfg.padding.enabled
     property bool floatingDialogs: main.isEnabled ? cfg.nativePanel.floatingDialogs : false
+    property bool floatingDialogsAllowOverride: main.isEnabled ? cfg.nativePanel.floatingDialogsAllowOverride : false
     property bool isEnabled: plasmoid.configuration.isEnabled
     property bool nativePanelBackgroundEnabled: (isEnabled ? cfg.nativePanel.background.enabled : true) || doPanelClickFix
     property real nativePanelBackgroundOpacity: isEnabled ? cfg.nativePanel.background.opacity : 1.0
@@ -1473,10 +1474,19 @@ PlasmoidItem {
         setFloatigApplets();
     }
 
+    onFloatingDialogsAllowOverrideChanged: {
+        setFloatigApplets();
+    }
+
     // inspired by https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1912
     function setFloatigApplets() {
         if (!containmentItem)
             return;
+        // Plasma 6.4 now has a floating applets option, but we are overriding it,
+        // so let's require the user to enable it before forcing one state of the other
+        if (main.plasmaVersion.isGreaterThan("6.3.5") && !floatingDialogsAllowOverride) {
+            return;
+        }
         if (floatingDialogs) {
             containmentItem.Plasmoid.containmentDisplayHints |= PlasmaCore.Types.ContainmentPrefersFloatingApplets;
         } else {

package/contents/ui/presets/Black Color Lines/settings.json

@@ -668,7 +668,8 @@
                 "opacity": 1,
                 "shadow": true
             },
-            "floatingDialogs": false
+            "floatingDialogs": false,
+            "floatingDialogsAllowOverride": false
         }
     }
 }

package/contents/ui/presets/Black Gray Lines/settings.json

@@ -668,7 +668,8 @@
                 "opacity": 1,
                 "shadow": true
             },
-            "floatingDialogs": false
+            "floatingDialogs": false,
+            "floatingDialogsAllowOverride": false
         }
     }
 }

package/contents/ui/presets/Black/settings.json

@@ -667,7 +667,8 @@
                 "opacity": 1,
                 "shadow": true
             },
-            "floatingDialogs": false
+            "floatingDialogs": false,
+            "floatingDialogsAllowOverride": false
         }
     }
 }

package/contents/ui/presets/Bliss Light/settings.json

@@ -918,7 +918,8 @@
                 "opacity": 0,
                 "shadow": false
             },
-            "floatingDialogs": true
+            "floatingDialogs": true,
+            "floatingDialogsAllowOverride": true
         }
     }
 }

package/contents/ui/presets/Bliss/settings.json

@@ -918,7 +918,8 @@
                 "opacity": 0,
                 "shadow": false
             },
-            "floatingDialogs": true
+            "floatingDialogs": true,
+            "floatingDialogsAllowOverride": true
         }
     }
 }

package/contents/ui/presets/Blur Widgets 2/settings.json

@@ -933,7 +933,8 @@
                 "opacity": 0,
                 "shadow": false
             },
-            "floatingDialogs": true
+            "floatingDialogs": true,
+            "floatingDialogsAllowOverride": true
         }
     }
 }

package/contents/ui/presets/Blur Widgets/settings.json

@@ -918,7 +918,8 @@
                 "opacity": 0,
                 "shadow": false
             },
-            "floatingDialogs": true
+            "floatingDialogs": true,
+            "floatingDialogsAllowOverride": true
         }
     }
 }