Skip to content

Commit cf101b5

Browse files
committed
fix: stuttering due to unique commands in executable datasource
apparently, connecting unique sources can cause stutter in the video being played, it was added as a way to avoid race conditions in callbacks but since the interval is now 1 second i think this cab be safely removed as the default command is very fast anyway perhaps I will explore why that is happenign in the first place at some point
1 parent 1fd9153 commit cf101b5

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

package/contents/ui/ScreenModel.qml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,7 @@ Item {
5353
onTriggered: {
5454
if (root.checkScreenState && !root.screenStateCmdRunning) {
5555
root.screenStateCmdRunning = true;
56-
// ensure each command is unique to avoid race condition where the
57-
// same command runs twice but the first run fails deleting the callback
58-
// that was going to be used by the second one
59-
runCommand.exec(root.screenStateCmd + `;t=${Date.now()}`, output => {
56+
runCommand.exec(root.screenStateCmd, output => {
6057
root.screenStateCmdRunning = false;
6158
if (output.exitCode === 0 && output.stdout.length > 0) {
6259
const out = output.stdout.trim().toLowerCase();

0 commit comments

Comments
 (0)