Skip to content

Commit 51df773

Browse files
authored
Merge pull request #60 from lukaszbudnik/correct-docker-cloud-builds
correct docker cloud integration
2 parents 6c7e2c6 + e34ad34 commit 51df773

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@ FROM golang:1.11.2-alpine3.8 as builder
22

33
MAINTAINER Łukasz Budnik [email protected]
44

5+
ARG SOURCE_BRANCH
6+
57
# build migrator
68
RUN apk add git
79
RUN go get -d -v github.com/lukaszbudnik/migrator
8-
RUN cd /go/src/github.com/lukaszbudnik/migrator && ./setup.sh
10+
RUN cd /go/src/github.com/lukaszbudnik/migrator && git checkout $SOURCE_BRANCH && ./setup.sh
911
RUN cd /go/src/github.com/lukaszbudnik/migrator && \
1012
GIT_BRANCH=$(git branch | awk -v FS=' ' '/\*/{print $NF}' | sed 's|[()]||g') && \
1113
GIT_COMMIT_SHA=$(git rev-list -1 HEAD) && \

TestDockerfile

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ FROM golang:1.11.2-alpine3.8 as builder
22

33
MAINTAINER Łukasz Budnik [email protected]
44

5-
# use "--build-arg BRANCH=migrator-v3" to override at build time
6-
# docker build -f TestDockerfile --build-arg BRANCH=migrator-v3 -t migratortest:v1 .
7-
ARG BRANCH=master
5+
# use "--build-arg SOURCE_BRANCH=migrator-v3" to override at build time
6+
# docker build -f TestDockerfile --build-arg SOURCE_BRANCH=migrator-v3 -t migratortest:v1 .
7+
ARG SOURCE_BRANCH=master
88

99
# git is required
1010
RUN apk add git
@@ -13,11 +13,10 @@ RUN apk add git
1313
#RUN mkdir -p /go/src/github.com/lukaszbudnik/migrator
1414
#COPY . /go/src/github.com/lukaszbudnik/migrator
1515

16-
# B - install migrator from $BRANCH branch
16+
# B - install migrator from $SOURCE_BRANCH branch
1717
RUN go get -d -v github.com/lukaszbudnik/migrator
18-
RUN cd /go/src/github.com/lukaszbudnik/migrator && git checkout $BRANCH
18+
RUN cd /go/src/github.com/lukaszbudnik/migrator && git checkout $SOURCE_BRANCH && ./setup.sh
1919

20-
RUN cd /go/src/github.com/lukaszbudnik/migrator && ./setup.sh
2120
RUN cd /go/src/github.com/lukaszbudnik/migrator && \
2221
GIT_BRANCH=$(git branch | awk -v FS=' ' '/\*/{print $NF}' | sed 's|[()]||g') && \
2322
GIT_COMMIT_SHA=$(git rev-list -1 HEAD) && \

hooks/build

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
#!/usr/bin/env sh
2+
3+
echo "Running custom build hook"
4+
5+
echo "SOURCE_BRANCH: $SOURCE_BRANCH"
6+
echo "SOURCE_COMMIT: $SOURCE_COMMIT"
7+
echo "DOCKERFILE_PATH: $DOCKERFILE_PATH"
8+
echo "DOCKER_REPO: $DOCKER_REPO"
9+
echo "CACHE_TAG: $CACHE_TAG"
10+
echo "IMAGE_NAME: $IMAGE_NAME"
11+
12+
docker build --build-arg SOURCE_BRANCH=$SOURCE_BRANCH -f $DOCKERFILE_PATH -t $IMAGE_NAME .

0 commit comments

Comments
 (0)