utils: Check for NULL guess in datum_secure_strequals (and always fail)

luke-jr · luke-jr · commit 99514921231a · 2026-01-05T18:56:56.000Z
diff --git a/src/datum_utils.c b/src/datum_utils.c
@@ -736,6 +736,7 @@ int datum_atoi_strict(const char * const s, const size_t size) {
 }
 
 bool datum_secure_strequals(const char *secret, size_t secret_len, const char *guess) {
+	if (!guess) return false;
 	const size_t guess_len = strlen(guess);
 	size_t acc = secret_len ^ guess_len;
 	if (!secret_len) {

Original file line number	Diff line number	Diff line change
`@@ -736,6 +736,7 @@ int datum_atoi_strict(const char * const s, const size_t size) {`
`736`	`736`	`}`
`737`	`737`
`738`	`738`	`bool datum_secure_strequals(const char secret, size_t secret_len, const char guess) {`
	`739`	`+ if (!guess) return false;`
`739`	`740`	`const size_t guess_len = strlen(guess);`
`740`	`741`	`size_t acc = secret_len ^ guess_len;`
`741`	`742`	`if (!secret_len) {`