Skip to content

Commit a856b4e

Browse files
authored
Backend paddle: switch default line_search_fn of L-BFGS to 'strong_wolfe' (#1790)
1 parent f34e81a commit a856b4e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

deepxde/model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -777,7 +777,7 @@ def _train_pytorch_lbfgs(self):
777777
)
778778

779779
n_iter = self.opt.state_dict()["state"][0]["n_iter"]
780-
if prev_n_iter == n_iter:
780+
if prev_n_iter == n_iter - 1:
781781
# Converged
782782
break
783783

@@ -809,7 +809,7 @@ def _train_paddle_lbfgs(self):
809809
)
810810

811811
n_iter = self.opt.state_dict()["state"]["n_iter"]
812-
if prev_n_iter == n_iter:
812+
if prev_n_iter == n_iter - 1:
813813
# Converged
814814
break
815815

deepxde/optimizers/paddle/optimizers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def get(params, optimizer, learning_rate=None, decay=None):
3434
tolerance_grad=LBFGS_options["gtol"],
3535
tolerance_change=LBFGS_options["ftol"],
3636
history_size=LBFGS_options["maxcor"],
37-
line_search_fn=None,
37+
line_search_fn=("strong_wolfe" if LBFGS_options["maxls"] > 0 else None),
3838
parameters=params,
3939
)
4040
return optim

0 commit comments

Comments
 (0)